Skip to content

feat(music): wide full player, keyboard shortcuts and volume - #186

Merged
A-EDev merged 5 commits into
mainfrom
feat/music-player-wide
Oct 25, 2026
Merged

A-EDev merged 5 commits into
mainfrom
feat/music-player-wide

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 9 of 22 of the music player plan (Android parity). Stacked on feat/music-player-colours (PR #185); review and merge in order.

  • From 1100 px wide the song stays on the left and a side pane shows Up next or the lyrics, with a button to give the lyrics the whole player. The artwork is sized from the space left.
  • Android's keys while the full player is open (Space/K, J/L/arrows, Up/Down, M, Shift+N/P, 0-9, S, R, Q), handled in the capture phase so a video page underneath never acts on them. Escape closes a menu first.
  • A volume button in the full player, wheel volume on both volume buttons, Shift+wheel seeking on the seek bar, an Up next hint on Next, and "Playing from".
  • The song menu adds Start radio, Equalizer, Not interested and Don't recommend this artist. The player is a dialog that takes focus and gives it back.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 529 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: not run on this branch (no Rust changes); clean at the top of the stack
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); no new warnings at the top of the stack
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); 825 passed, 0 failed at the top of the stack
  • I smoke-tested the affected desktop behavior. macOS: two-pane layout and lyrics tab (screenshots); Space pauses, K resumes, Down lowers volume, L seeks 10 s; Escape closes the menu, then the player.
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the feat/music-player-colours branch from f68e1c6 to 14118c7 Compare October 25, 2026 19:31
@A-EDev
A-EDev force-pushed the feat/music-player-wide branch from 9eb6c0a to cc6b90c Compare October 25, 2026 19:31
@A-EDev
A-EDev changed the base branch from feat/music-player-colours to main October 25, 2026 19:31
@A-EDev
A-EDev merged commit 6f4fc3e into main Oct 25, 2026
1 check passed
@A-EDev
A-EDev deleted the feat/music-player-wide branch October 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants