Skip to content

feat(music): Immersive background and Watch video - #187

Merged
A-EDev merged 5 commits into
mainfrom
feat/music-immersive
Oct 25, 2026
Merged

A-EDev merged 5 commits into
mainfrom
feat/music-immersive

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 10 of 22 of the music player plan (Android parity). Stacked on feat/music-player-wide (PR #186); review and merge in order.

  • Immersive Artwork: the cover full-bleed at the top, or on the start side of a wide player, fading into its blurred continuation, as on Android. The backdrop now loads the cover through the same proxied copy as the artwork.
  • Watch video in the song menu finds the official video with Android's MusicVideoMatching rules and opens it in the video player at the same moment.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 533 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: not run on this branch (no Rust changes); clean at the top of the stack
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); no new warnings at the top of the stack
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); 825 passed, 0 failed at the top of the stack
  • I smoke-tested the affected desktop behavior. macOS: Immersive on the wide player (screenshot); 8 of 8 trending songs matched an official video; the video opened at 8 s with the song paused at 7 s.
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the feat/music-player-wide branch from 9eb6c0a to cc6b90c Compare October 25, 2026 19:31
@A-EDev
A-EDev force-pushed the feat/music-immersive branch from 98469b5 to d5c5649 Compare October 25, 2026 19:32
@A-EDev
A-EDev changed the base branch from feat/music-player-wide to main October 25, 2026 19:32
@A-EDev
A-EDev merged commit 3660fa2 into main Oct 25, 2026
1 check passed
@A-EDev
A-EDev deleted the feat/music-immersive branch October 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants