Skip to content

fix(music): keep the full player dark in light themes - #182

Merged
A-EDev merged 2 commits into
mainfrom
fix/music-player-contrast
Oct 25, 2026
Merged

A-EDev merged 2 commits into
mainfrom
fix/music-player-contrast

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part 5 of 22 of the music player plan (Android parity). Stacked on fix/music-eq-headroom (PR #181); review and merge in order.

  • The full player draws with the theme's dark tokens in every theme, as Android does, so its title, controls and lyrics are no longer dark on a dark backdrop. scopeVariables also sets the Tailwind tokens derived from the -val variables, which @theme resolves at the root.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test: 446 tests passed, 0 failed
  • pnpm build: passed
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: not run on this branch (no Rust changes); clean at the top of the stack
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); no new warnings at the top of the stack
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: not run on this branch (no Rust changes); 825 passed, 0 failed at the top of the stack
  • I smoke-tested the affected desktop behavior. macOS: light theme, full player: title colour rgb(244,244,244) on the dark player, queue pane readable (screenshot checked).
  • OS/device: device testing by the owner. The checks above ran on macOS 27 (Apple Silicon MacBook Pro, 120 Hz) in a dev build of the whole stack; Windows and Linux were not run.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed (changelog entry in v0.1.0-beta3.txt).
  • Dependency and lockfile changes are intentional and limited to this PR. No dependency changes.
  • Breaking changes and upgrade steps are clearly documented. No breaking changes.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev force-pushed the fix/music-eq-headroom branch from 40c292a to 9c646cd Compare October 25, 2026 19:29
@A-EDev
A-EDev force-pushed the fix/music-player-contrast branch from 3022735 to 64568f8 Compare October 25, 2026 19:30
@A-EDev
A-EDev changed the base branch from fix/music-eq-headroom to main October 25, 2026 19:30
@A-EDev
A-EDev merged commit 871a47d into main Oct 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants