Skip to content

deps(api): Upgrade django-clickhouse-backend to 2.0 - #8373

Closed
khvn26 wants to merge 1 commit into
mainfrom
chore/api-clickhouse-backend-2
Closed

deps(api): Upgrade django-clickhouse-backend to 2.0#8373
khvn26 wants to merge 1 commit into
mainfrom
chore/api-clickhouse-backend-2

Conversation

@khvn26

@khvn26 khvn26 commented Aug 26, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

In this PR, we bump django-clickhouse-backend to 2.0. This allows us to remove clickhouse-driver from override-dependencies.

@khvn26
khvn26 requested a review from a team as a code owner August 26, 2026 06:34
@khvn26
khvn26 requested review from matthewelwell and removed request for a team August 26, 2026 06:34
@vercel

vercel Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Aug 26, 2026 10:38am
flagsmith-frontend-preview Ignored Ignored Preview Aug 26, 2026 10:38am
flagsmith-frontend-staging Ignored Ignored Preview Aug 26, 2026 10:38am

Request Review

@khvn26 khvn26 mentioned this pull request Aug 26, 2026
Closed
4 tasks
@github-actions github-actions Bot added the api Issue related to the REST API label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The API project now requires django-clickhouse-backend version 2 through version 3. The uv Git source override was removed. The existing exact-version override configuration remains.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: 🟡 Moderate · up to 386fb

The dependency upgrade changes ClickHouse test-database cloning while retaining an override that can produce incorrect table references, parallel test failures, or replication-path collisions. The PR is not merge-ready until the override is removed or delegated to the backend 2.0 implementation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8373 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8373 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8373 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8373 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8373 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8373 Finished ✅ Results ✅

coderabbitai[bot]
coderabbitai Bot reviewed Aug 26, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 37514484-4d77-4697-b977-f39ca212ed0f

📥 Commits

Reviewing files that changed from the base of the PR and between 0be48ea and 386fb2e.

⛔ Files ignored due to path filters (1)
  • api/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • api/pyproject.toml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Comment thread api/pyproject.toml
@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #19823 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  55.4 seconds
commit  224b3af
info  🔄 Run: #19823 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19823 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 2 suites
duration  1 minute, 1 second
commit  224b3af
info  🔄 Run: #19823 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19823 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.7 seconds
commit  224b3af
info  🔄 Run: #19823 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19823 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.2 seconds
commit  224b3af
info  🔄 Run: #19823 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19805 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  38.3 seconds
commit  ba80023
info  🔄 Run: #19805 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19805 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 4 seconds
commit  ba80023
info  🔄 Run: #19805 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19805 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.8 seconds
commit  ba80023
info  🔄 Run: #19805 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19805 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.6 seconds
commit  ba80023
info  🔄 Run: #19805 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19782 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  38.1 seconds
commit  0bc041d
info  🔄 Run: #19782 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19782 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  33 seconds
commit  0bc041d
info  🔄 Run: #19782 (attempt 1)

❌ oss · depot-ubuntu-latest-16 — run #19782 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  21.7 seconds
commit  0bc041d
info  📦 Artifacts: View test results and HTML report
🔄 Run: #19782 (attempt 1)

Failed tests

firefox › tests/segment-test.pw.ts › Segment test 1 - Create, update, and manage segments with multivariate flags @oss

✅ private-cloud · depot-ubuntu-latest-16 — run #19778 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  32.1 seconds
commit  386fb2e
info  🔄 Run: #19778 (attempt 1)

@codecov

codecov Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (277a086) to head (224b3af).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8373      +/-   ##
==========================================
+ Coverage   98.74%   98.80%   +0.05%     
==========================================
  Files        1619     1619              
  Lines       65655    65682      +27     
==========================================
+ Hits        64834    64898      +64     
+ Misses        821      784      -37

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@khvn26
khvn26 force-pushed the chore/api-clickhouse-backend-2 branch from 386fb2e to 0bc041d Compare August 26, 2026 07:04
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
@khvn26
khvn26 force-pushed the chore/api-clickhouse-backend-2 branch from 0bc041d to ba80023 Compare August 26, 2026 09:28
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
@khvn26
deps(api): upgrade django-clickhouse-backend to 2.0
224b3af 
1.6 pinned `clickhouse-driver==0.2.10` while the api requires 0.2.11, so
resolution only succeeded via a `clickhouse-driver` override plus a git
pin on the unreleased fix commit. Overrides don't propagate to
consumers, so any project depending on flagsmith-api could not resolve
it at all.

2.0 pins `clickhouse-driver==0.2.11` itself, so both workarounds go.

Ref: jayvynl/django-clickhouse-backend#172
@khvn26
khvn26 force-pushed the chore/api-clickhouse-backend-2 branch from ba80023 to 224b3af Compare August 26, 2026 10:38
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
@khvn26

khvn26 commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Superseded by #8375

@khvn26 khvn26 closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

No one assigned

Labels

api Issue related to the REST API dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khvn26 @matthewelwell