Skip to content

deps(api): Upgrade pyfakefs to 6.x - #8374

Closed
khvn26 wants to merge 1 commit into
chore/api-clickhouse-backend-2from
chore/api-pyfakefs-6
Closed

deps(api): Upgrade pyfakefs to 6.x#8374
khvn26 wants to merge 1 commit into
chore/api-clickhouse-backend-2from
chore/api-pyfakefs-6

Conversation

@khvn26

@khvn26 khvn26 commented Aug 26, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Stacked on #8373.

In this PR, we remove pyfakefs from override-dependencies, which moves us onto pyfakefs 6.2.0.

How did you test this code?

Green CI should suffice.

@khvn26
khvn26 requested a review from a team as a code owner August 26, 2026 06:34
@khvn26
khvn26 requested review from matthewelwell and removed request for a team August 26, 2026 06:34
@vercel

vercel Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Aug 26, 2026 10:38am
flagsmith-frontend-preview Ignored Ignored Preview Aug 26, 2026 10:38am
flagsmith-frontend-staging Ignored Ignored Preview Aug 26, 2026 10:38am

Request Review

@khvn26 khvn26 mentioned this pull request Aug 26, 2026
Merged
4 tasks
@github-actions github-actions Bot added the api Issue related to the REST API label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1e48c754-7095-46b3-8bad-f63c22f1a4d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8374 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8374 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8374 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8374 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8374 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8374 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8374 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8374 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8374 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8374 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19819 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  38 seconds
commit  3f0a34d
info  🔄 Run: #19819 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19821 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 11 seconds
commit  3f0a34d
info  🔄 Run: #19821 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19819 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  32.3 seconds
commit  3f0a34d
info  🔄 Run: #19819 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19821 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  33 seconds
commit  3f0a34d
info  🔄 Run: #19821 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19821 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  47.2 seconds
commit  3f0a34d
info  🔄 Run: #19821 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19819 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.6 seconds
commit  3f0a34d
info  🔄 Run: #19819 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19821 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.7 seconds
commit  3f0a34d
info  🔄 Run: #19821 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19819 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.2 seconds
commit  3f0a34d
info  🔄 Run: #19819 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19806 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  58.1 seconds
commit  2e7c088
info  🔄 Run: #19806 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19810 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  2e7c088
info  🔄 Run: #19810 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19806 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  39.4 seconds
commit  2e7c088
info  🔄 Run: #19806 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19808 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  56.4 seconds
commit  2e7c088
info  🔄 Run: #19808 (attempt 1)

@codecov

codecov Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (224b3af) to head (3f0a34d).

Additional details and impacted files 
@@                       Coverage Diff                       @@
##           chore/api-clickhouse-backend-2    #8374   +/-   ##
===============================================================
  Coverage                           98.80%   98.80%           
===============================================================
  Files                                1619     1619           
  Lines                               65682    65682           
===============================================================
  Hits                                64898    64898           
  Misses                                784      784

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@khvn26
khvn26 force-pushed the chore/api-clickhouse-backend-2 branch from 386fb2e to 0bc041d Compare August 26, 2026 07:04
@khvn26
khvn26 force-pushed the chore/api-pyfakefs-6 branch from 8b90483 to 2d588a4 Compare August 26, 2026 07:04
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
matthewelwell
matthewelwell previously approved these changes Aug 26, 2026
View reviewed changes
@khvn26
khvn26 force-pushed the chore/api-clickhouse-backend-2 branch from 0bc041d to ba80023 Compare August 26, 2026 09:28
@khvn26
khvn26 force-pushed the chore/api-pyfakefs-6 branch from 2d588a4 to 2e7c088 Compare August 26, 2026 09:28
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
@khvn26
khvn26 requested a review from matthewelwell August 26, 2026 10:24
matthewelwell
matthewelwell previously approved these changes Aug 26, 2026
View reviewed changes
@khvn26
deps(api): upgrade pyfakefs to 6.x
3f0a34d 
`flagsmith-common[test-tools]` has required `pyfakefs>=6,<7` since
3.13.1, but the api capped it at `<6.0.0` and pinned `==5.7.4` via an
override. The override kept the api resolvable while leaving the
declared metadata contradictory, so consumers of flagsmith-api could not
resolve the two together.

Ref: #8368
@khvn26
khvn26 force-pushed the chore/api-pyfakefs-6 branch from 2e7c088 to 3f0a34d Compare August 26, 2026 10:38
@khvn26
khvn26 force-pushed the chore/api-clickhouse-backend-2 branch from ba80023 to 224b3af Compare August 26, 2026 10:38
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Aug 26, 2026
@khvn26

khvn26 commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Superseded by #8375

@khvn26 khvn26 closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

No one assigned

Labels

api Issue related to the REST API dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khvn26 @matthewelwell