Skip to content

fix: extracted-update-segment-test #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewelwell merged 11 commits into from
Aug 21, 2025
Merged

fix: extracted-update-segment-test #5951

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6666415
fix: extracted-update-segment
Zaimwa9 Aug 20, 2025
7767916
fix: updated-test
Zaimwa9 Aug 20, 2025
2530866
fix: temporarily-run-against-prod
Zaimwa9 Aug 20, 2025
9bd9666
fix: worked-on-sequence-of-tests
Zaimwa9 Aug 20, 2025
717fe48
fix: use-current-commit-in-workflow
Zaimwa9 Aug 20, 2025
6f991b7
fix: removed-vs-prod-step
Zaimwa9 Aug 20, 2025
64ec4f3
fix: wait-and-refresh-post-update
Zaimwa9 Aug 20, 2025
3994bff
fix: removed-update-test
Zaimwa9 Aug 20, 2025
f3fe4cb
fix: changed-order-of-the-test
Zaimwa9 Aug 20, 2025
5fcaa40
fix: re-added-against-prod-step
Zaimwa9 Aug 20, 2025
6febe1f
fix: removed-e2e-prod-step
Zaimwa9 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions frontend/e2e/tests/segment-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const segmentRules = [
]

export const testSegment1 = async (flagsmith: any) => {
const isCloneSegmentEnabled = await flagsmith.hasFeature('clone_segment')
log('Login')
await login(E2E_USER, PASSWORD)
await click('#project-select-1')
Expand All @@ -90,26 +91,14 @@ export const testSegment1 = async (flagsmith: any) => {
{ value: 'small', weight: 0 },
])

log('Segment age rules')
await gotoSegments()

log('Segment age rules')
// (=== 18 || === 19) && (> 17 || < 19) && (!=20) && (<=18) && (>=18)
// Rule 1- Age === 18 || Age === 19

await createSegment(0, '18_or_19', segmentRules)

log('Update segment')
await click(byId('segment-0-name'))
const lastRule = segmentRules[segmentRules.length - 1]
await setSegmentRule(segmentRules.length - 1, 0, lastRule.name, lastRule.operator, lastRule.value + 1)
await click(byId('update-segment'))
await closeModal()
await gotoSegments()
await click(byId('segment-0-name'))
await assertInputValue(byId(`rule-${segmentRules.length - 1}-value-0`), `${lastRule.value + 1}`)
await setSegmentRule(segmentRules.length - 1, 0, lastRule.name, lastRule.operator, lastRule.value)
await click(byId('update-segment'))
await closeModal()

log('Add segment trait for user')
await gotoTraits()
await createTrait(0, 'age', 18)
Expand Down Expand Up @@ -142,7 +131,6 @@ export const testSegment1 = async (flagsmith: any) => {
await waitAndRefresh()
await assertTextContent(byId('user-feature-value-0'), '"medium"')

const isCloneSegmentEnabled = await flagsmith.hasFeature('clone_segment')
if (isCloneSegmentEnabled) {
log('Clone segment')
await gotoSegments()
Expand All @@ -155,6 +143,22 @@ export const testSegment1 = async (flagsmith: any) => {
await deleteSegment(0, '18_or_19', !isCloneSegmentEnabled)
await gotoFeatures()
await deleteFeature(0, 'mv_flag')

log('Update segment')
await gotoSegments()
const lastRule = segmentRules[segmentRules.length - 1]
await createSegment(0, 'segment_to_update', [lastRule])
await closeModal()
await click(byId('segment-0-name'))
await setSegmentRule(0, 0, lastRule.name, lastRule.operator, lastRule.value + 1)
await click(byId('update-segment'))
await closeModal()
await gotoSegments()
await click(byId('segment-0-name'))
await assertInputValue(byId(`rule-${0}-value-0`), `${lastRule.value + 1}`)
await closeModal()
await deleteSegment(0, 'segment_to_update', !isCloneSegmentEnabled)
await waitAndRefresh()
}

export const testSegment2 = async () => {
Expand Down
Loading