Skip to content

fix: extracted-update-segment-test - #5951

Merged
matthewelwell merged 11 commits into
mainfrom
fix/separate-update-segment-condition-test
Aug 21, 2025
Merged

fix: extracted-update-segment-test#5951
matthewelwell merged 11 commits into
mainfrom
fix/separate-update-segment-condition-test

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Extracted test to have it with one rule to avoid re-ordering conflicts

How did you test this code?

  • test

@Zaimwa9
Zaimwa9 requested a review from a team as a code owner August 20, 2025 13:24
@Zaimwa9
Zaimwa9 requested review from kyle-ssg and removed request for a team August 20, 2025 13:24
@vercel

vercel Bot commented Aug 20, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Aug 20, 2025 5:30pm
flagsmith-frontend-preview Ignored Ignored Preview Aug 20, 2025 5:30pm
flagsmith-frontend-staging Ignored Ignored Preview Aug 20, 2025 5:30pm

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Aug 20, 2025
@github-actions

github-actions Bot commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5951 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5951 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5951 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5951 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5951 Finished ✅ Results

@Zaimwa9
Zaimwa9 requested a review from a team as a code owner August 20, 2025 15:02
@github-actions github-actions Bot added fix and removed fix labels Aug 20, 2025
Comment thread .github/workflows/platform-pull-request.yml Fixed
@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.86%. Comparing base (023a547) to head (5fcaa40).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5951      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files        1275     1275              
  Lines       45217    45227      +10     
==========================================
+ Hits        44252    44261       +9     
- Misses        965      966       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the fix label Aug 20, 2025
@github-actions github-actions Bot added fix and removed fix labels Aug 20, 2025
@github-actions github-actions Bot added fix and removed fix labels Aug 20, 2025
@matthewelwell
matthewelwell merged commit bac797a into main Aug 21, 2025
25 checks passed
@matthewelwell
matthewelwell deleted the fix/separate-update-segment-condition-test branch August 21, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants