Skip to content

fix: check-split-length-before-accessing-with-index - #5848

Merged
Zaimwa9 merged 8 commits into
mainfrom
fix/invalid-email-login-throws-500
Aug 14, 2025
Merged

fix: check-split-length-before-accessing-with-index#5848
Zaimwa9 merged 8 commits into
mainfrom
fix/invalid-email-login-throws-500

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

closes #4951

Changes

  • Check split length before accessing

How did you test this code?

Added test in models
To reproduce:
Try login with invalid email

New error (without auth-controller cf this PR):

    "non_field_errors": [
        "Unable to log in with provided credentials."
    ]
}

@Zaimwa9
Zaimwa9 requested a review from a team as a code owner July 29, 2025 14:17
@Zaimwa9
Zaimwa9 requested review from emyller and removed request for a team July 29, 2025 14:17
@vercel

vercel Bot commented Jul 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs ⬜️ Ignored Preview Aug 13, 2025 3:05pm
flagsmith-frontend-preview ⬜️ Ignored Preview Aug 13, 2025 3:05pm
flagsmith-frontend-staging ⬜️ Ignored Preview Aug 13, 2025 3:05pm

@github-actions github-actions Bot added the api Issue related to the REST API label Jul 29, 2025
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5848 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5848 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5848 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5848 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5848 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5848 Finished ✅ Results

@github-actions github-actions Bot added the fix label Jul 29, 2025
@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.84%. Comparing base (1411f54) to head (2f0368e).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5848      +/-   ##
==========================================
+ Coverage   97.82%   97.84%   +0.02%     
==========================================
  Files        1258     1261       +3     
  Lines       44745    44899     +154     
==========================================
+ Hits        43771    43933     +162     
+ Misses        974      966       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread api/integrations/lead_tracking/hubspot/services.py Outdated
Comment thread api/tests/unit/users/test_unit_users_models.py Outdated
Comment thread api/users/models.py Outdated
Zaimwa9 and others added 2 commits August 13, 2025 11:01
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
@github-actions github-actions Bot added fix and removed fix labels Aug 13, 2025
@github-actions github-actions Bot added fix and removed fix labels Aug 13, 2025
@Zaimwa9
Zaimwa9 requested a review from emyller August 13, 2025 09:54
@github-actions github-actions Bot added fix and removed fix labels Aug 13, 2025
@github-actions github-actions Bot added fix and removed fix labels Aug 13, 2025
Comment thread api/custom_auth/serializers.py Outdated
@github-actions github-actions Bot added fix and removed fix labels Aug 13, 2025
@github-actions github-actions Bot removed the fix label Aug 13, 2025
@github-actions github-actions Bot added the fix label Aug 13, 2025
@Zaimwa9
Zaimwa9 merged commit e5740aa into main Aug 14, 2025
29 checks passed
@Zaimwa9
Zaimwa9 deleted the fix/invalid-email-login-throws-500 branch August 14, 2025 07:22
matthewelwell added a commit that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging in with an invalid email address (without an '@' character) causes 500

2 participants