fix: correct implementation for email validation on login - #5945
Closed
matthewelwell wants to merge 1 commit into
Closed
fix: correct implementation for email validation on login#5945matthewelwell wants to merge 1 commit into
matthewelwell wants to merge 1 commit into
Conversation
matthewelwell
requested review from
gagantrivedi
and removed request for
a team
August 20, 2025 10:42
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
matthewelwell
requested review from
Zaimwa9
and removed request for
gagantrivedi
August 20, 2025 10:42
Contributor
Docker builds report
|
Zaimwa9
reviewed
Aug 20, 2025
| ) | ||
|
|
||
|
|
||
| class CustomTokenCreateSerializer(TokenCreateSerializer): # type: ignore[misc] |
Contributor
There was a problem hiding this comment.
I think it just needs to be added to the view to pass
serializer_class = CustomTokenCreateSerializer
Thanks for jumping on it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a re-implementation of #5848 , but I need to verify with @Zaimwa9 what the reason for the original implementation is at it seems unnecessary to me.
How did you test this code?
Updated / added unit tests.