Skip to content

Potential fix for code scanning alert no. 6: Clear-text storage of sensitive information #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkterry1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Potential fix for code scanning alert no. 6: Clear-text storage of sensitive information #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions cores/flycast/intl/crowdin_translation_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,9 @@
DIR_PATH = t.os.path.dirname(t.os.path.realpath(__file__))
YAML_PATH = t.os.path.join(DIR_PATH, 'crowdin.yaml')

# Apply Crowdin API Key
# Apply core name placeholder (do not persist API token to disk)
with open(YAML_PATH, 'r') as crowdin_config_file:
crowdin_config = crowdin_config_file.read()
crowdin_config = re.sub(r'"api_token": "_secret_"',
f'"api_token": "{API_KEY}"',
crowdin_config, 1)
crowdin_config = re.sub(r'/_core_name_',
f'/{CORE_NAME}'
, crowdin_config)
Expand Down Expand Up @@ -58,16 +55,11 @@
shutil.rmtree(jar_dir)

print('download translation *.json')
subprocess.run(['java', '-jar', jar_path, 'download', '--config', YAML_PATH])
crowdin_env = os.environ.copy()
crowdin_env['CROWDIN_PERSONAL_TOKEN'] = API_KEY
subprocess.run(['java', '-jar', jar_path, 'download', '--config', YAML_PATH], env=crowdin_env)

# Reset Crowdin API Key
with open(YAML_PATH, 'r') as crowdin_config_file:
crowdin_config = crowdin_config_file.read()
crowdin_config = re.sub(r'"api_token": ".*?"',
'"api_token": "_secret_"',
crowdin_config, 1)

# TODO this is NOT safe!
# Restore core name placeholder
crowdin_config = re.sub(re.escape(f'/{CORE_NAME}'),
'/_core_name_',
crowdin_config)
Expand All @@ -76,14 +68,10 @@
crowdin_config_file.write(crowdin_config)

except Exception as e:
# Try really hard to reset Crowdin API Key
# Try really hard to restore core name placeholder
with open(YAML_PATH, 'r') as crowdin_config_file:
crowdin_config = crowdin_config_file.read()
crowdin_config = re.sub(r'"api_token": ".*?"',
'"api_token": "_secret_"',
crowdin_config, 1)

# TODO this is NOT safe!
crowdin_config = re.sub(re.escape(f'/{CORE_NAME}'),
'/_core_name_',
crowdin_config)
Expand Down
Loading