Potential fix for code scanning alert no. 6: Clear-text storage of sensitive information - #256
Open
jkterry1 wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 6: Clear-text storage of sensitive information#256jkterry1 wants to merge 1 commit into
jkterry1 wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jkterry1
marked this pull request as ready for review
August 2, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Farama-Foundation/Stable-Retro/security/code-scanning/6
General fix: do not persist secrets to files. Keep the token in memory and provide it only at execution time through a less persistent channel (process environment). Also avoid mutating
crowdin.yamlwith the token.Best fix here (without changing functionality): keep replacing only
/_core_name_incrowdin.yaml, but remove all code that writesapi_tokeninto the YAML. Then call Crowdin CLI with an environment variable containing the token (Crowdin CLI supports token via env var), usingsubprocess.run(..., env=...). This preserves behavior (CLI still authenticates) while eliminating clear-text token-at-rest in project files.Edits needed in
cores/flycast/intl/crowdin_translation_download.py:"api_token": "_secret_"and the corresponding reset logic for api token in bothtryandexcept.subprocess.runand passCROWDIN_PERSONAL_TOKENviaenv./_core_name_in both success and exception paths.Suggested fixes powered by Copilot Autofix. Review carefully before merging.