Enforce typed test and tooling boundaries by HardlyDifficult · Pull Request #425 · Fairmint/ocp-canton-sdk

HardlyDifficult · 2026-07-10T05:24:12Z

Summary

enforce unknown-first, no-explicit-any boundaries across production fixtures, tests, mocks, and scripts
make the Canton mock honor amulet_rules.domain_id and cover conflicting-domain behavior
remove dead fixture exports and parse dynamically prepared fixtures into their exact OCF entity types
add recursive type assertions that detect nested any in source, built declarations, and package-consumer contracts
verify exact self-package configuration and package artifacts from a clean build

Validation

full Jest suite passes
npm run test:declarations
npm run test:package-consumer
npm run test:exact-public-config
npm run typecheck
npm run build
npm run lint
npm run format
npm pack --dry-run
CI and OCP QuickStart pass on exact head 22d8fb1b0bdf3ea34e43617d0c6e81d39c5b16bf

Stack

stacked on Enforce non-empty OCF arrays and quality guardrails #424
remains draft until its parent reaches the final review gate

coderabbitai · 2026-07-10T05:24:21Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d1bb263b-8712-4c24-806b-2b1d67ecc8d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Note

Reviews paused

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/typed-test-infrastructure

_{Comment @coderabbitai help to get the list of available commands.}

…est-infrastructure

…ils' into codex/typed-test-infrastructure # Conflicts: # test/integration/production/productionDataRoundtrip.integration.test.ts

HardlyDifficult · 2026-07-10T19:01:27Z

Current head 32ad56c is green, merge-clean, unassigned, and thread-free. Advancing to Stage 2 and queuing automated review. CodeRabbit is deferred to the org-wide cooldown and remains queued without a ping.

HardlyDifficult · 2026-07-10T19:01:28Z

@copilot review

HardlyDifficult · 2026-07-10T19:01:29Z

cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 32ad56c. Configure here.}

Copilot · 2026-07-10T19:03:43Z

@copilot review

Reviewed the current head (32ad56c). No additional changes are needed from my side at this time.

HardlyDifficult · 2026-07-10T19:20:39Z

Returned to draft because upstream schema-boundary branches #417–#421 have new material fixes that still need to be propagated through this stacked PR. Exact-head CI and Copilot-first bot review will be refreshed after the ordered restack.

HardlyDifficult · 2026-07-10T20:27:54Z

@coderabbitai pause

coderabbitai · 2026-07-10T20:28:01Z

✅ Action performed

Reviews paused.

…ped-test-infrastructure

HardlyDifficult · 2026-07-10T22:55:22Z

Exact head 4a1dc8b is merge-clean with CI and QuickStart green and no unresolved review threads.

@copilot review

Copilot · 2026-07-10T22:56:41Z

Exact head 4a1dc8b is merge-clean with CI and QuickStart green and no unresolved review threads.

@copilot review

Reviewed current head 4a1dc8b. No additional changes are needed from my side.

…ped-test-infrastructure

…ped-test-infrastructure # Conflicts: # package.json # scripts/check-declarations.ts # test/exact/builtPublicConfig.types.ts # test/exact/sourcePublicConfig.types.ts

HardlyDifficult · 2026-07-12T03:20:56Z

Corrected stack propagation is pushed at 689f0d222214fa658b9395c071956ea27c50702e, incorporating exact parent #424 8968c1f5f7f1e2e2435d66a50338f3b8a1748343.

Validation on this exact head:

full test:ci: 91 suites / 5,287 tests, coverage passing
hardened test:declarations pipeline passing after a clean build
package entrypoint artifacts, source-vs-built canonical inventory, declaration compilation, exact public config, built cardinality, and real package-consumer resolution all checked
package consumer compiles with exactOptionalPropertyTypes and noUncheckedIndexedAccess; current environment discriminants include staging
source and built exact config assertions preserve required OAuth credentials, forbid MainNet shared-secret auth, and retain all parent immutable/omission-only contracts
source and built inventories agree: 55 canonical variants, 0 aliases, fingerprint 39418162cb257fc316d7a15efc24d825223fac9a9d9d4d2d5104cc53ebb444c0
typecheck, ESLint, Prettier, and diff checks passing

The PR remains draft and unassigned while fresh CI runs on this material revision. No reviewer requests were made during propagation.

HardlyDifficult · 2026-07-12T07:29:10Z

@copilot review

Please review exact current head 689f0d222214fa658b9395c071956ea27c50702e. Pre-review gate: both required checks are successful, GitHub is CLEAN/MERGEABLE, the PR is unassigned, and zero review threads are unresolved. Focus on typed test infrastructure, declaration assertions that cannot degrade to any, package-consumer parity, and failure-signal quality. Report every actionable current-head issue before the other reviewers.

Copilot · 2026-07-12T07:31:20Z

@copilot review

Please review exact current head 689f0d222214fa658b9395c071956ea27c50702e. Pre-review gate: both required checks are successful, GitHub is CLEAN/MERGEABLE, the PR is unassigned, and...

Reviewed exact current head 689f0d222214fa658b9395c071956ea27c50702e against stacked base codex/schema-cardinality-guardrails. I don’t see any additional actionable current-head issues to address.

HardlyDifficult · 2026-07-12T07:32:24Z

@cursor review

Please review exact current head 689f0d222214fa658b9395c071956ea27c50702e. Copilot completed its required exact-head pass with no actionable findings: #425 (comment). Both required checks are green, GitHub is CLEAN/MERGEABLE, and zero review threads are unresolved. Focus on typed test infrastructure, any-resistant exactness assertions, package-consumer parity, and meaningful failure signals.

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 689f0d2. Configure here.}

HardlyDifficult · 2026-07-12T08:00:32Z

Upstream PR #424 advanced materially with the shared dense-array security boundary and corrected #423 parent. Returning this stacked PR to draft while I propagate exact parent 1557d19b5ef42e2ec99dd8f875cb72f3fbac347c, validate the integrated tree, and rerun exact-head reviewer gates.

…ped-test-infrastructure

HardlyDifficult · 2026-07-12T08:07:27Z

Corrected parent #424 is integrated and the independent audit’s exactness finding is fixed at 8b2caa991c0ad8ace14edaf8f00bb4c811eaf0c2. All source, built, and installed-package IsExactly helpers now reject any on either operand, with lint-safe meta-assertions that fail compilation if this regresses.

Independent final validation is green: targeted 7 suites / 235 tests; full test:ci 91 suites / 5,292 tests; clean build/declaration graph/exact-public/built-cardinality/package-consumer; typecheck; lint; formatting; ancestry and diff checks. This PR remains draft and unassigned while fresh remote CI runs; Copilot will be requested first on the new exact head.

HardlyDifficult · 2026-07-12T08:16:22Z

@copilot review

Please review exact current head 8b2caa991c0ad8ace14edaf8f00bb4c811eaf0c2 against exact parent 1557d19b5ef42e2ec99dd8f875cb72f3fbac347c. This revision preserves the typed test infrastructure while making source, built, and installed-package IsExactly helpers reject any on either operand, with meta-assertions that fail if the guard regresses. Pre-review: both checks green, CLEAN/MERGEABLE, unassigned, zero threads. Focus on declaration-test soundness, any resistance, package exports, compiler-flag probes, and parent guardrail integration. Report all actionable issues before Cursor and CodeRabbit.

Copilot · 2026-07-12T08:19:40Z

@copilot review

Please review exact current head 8b2caa991c0ad8ace14edaf8f00bb4c811eaf0c2 against exact parent 1557d19b5ef42e2ec99dd8f875cb72f3fbac347c. This revision preserves the typed test inf...

Reviewed exact head 8b2caa991c0ad8ace14edaf8f00bb4c811eaf0c2 against parent 1557d19b5ef42e2ec99dd8f875cb72f3fbac347c with focus on declaration-test soundness, any resistance in IsExactly, package-consumer parity, compiler-flag probes, and parent guardrail integration. I don’t see any additional actionable current-head issues to address.

HardlyDifficult · 2026-07-12T08:25:12Z

@cursor review\n\nCopilot has completed an exact-head substantive review of 8b2caa9 with no actionable findings. Please now review this exact head, including the hardened IsExactly any guards and source/built/package-consumer type-test parity.

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 8b2caa9. Configure here.}

HardlyDifficult · 2026-07-12T08:41:22Z

Returned to draft because upstream #417 received a material exact-head corrective revision after full CodeRabbit review. This stacked PR will remain held until the audited #417 head and each intervening parent are propagated normally; fresh CI and Copilot-first reviewer gates are required afterward.

…ped-test-infrastructure

Harden test and tooling type boundaries

325fa1c

HardlyDifficult mentioned this pull request Jul 10, 2026

Type OCF manifest extraction end to end #426

Draft

HardlyDifficult added 3 commits July 10, 2026 12:47

Merge branch 'codex/schema-cardinality-guardrails' into codex/typed-t…

e720943

…est-infrastructure

Merge branch 'codex/schema-cardinality-guardrails' into codex/typed-t…

125560b

…est-infrastructure

Merge remote-tracking branch 'origin/codex/schema-cardinality-guardra…

32ad56c

…ils' into codex/typed-test-infrastructure # Conflicts: # test/integration/production/productionDataRoundtrip.integration.test.ts

HardlyDifficult marked this pull request as ready for review July 10, 2026 19:01

Copilot started work on behalf of HardlyDifficult July 10, 2026 19:02 View session

cursor Bot reviewed Jul 10, 2026

View reviewed changes

Copilot finished work on behalf of HardlyDifficult July 10, 2026 19:04

HardlyDifficult marked this pull request as draft July 10, 2026 19:20

HardlyDifficult added 2 commits July 10, 2026 17:56

Harden typed transaction tree fixtures

0fe31fc

Merge commit 'e7ffd298f5cc27bbb596a08b3c41a9b60c70b95a' into codex/ty…

4a1dc8b

…ped-test-infrastructure

HardlyDifficult marked this pull request as ready for review July 10, 2026 22:55

Copilot started work on behalf of HardlyDifficult July 10, 2026 22:56 View session

HardlyDifficult marked this pull request as draft July 10, 2026 22:57

Copilot finished work on behalf of HardlyDifficult July 10, 2026 22:57

HardlyDifficult added 4 commits July 10, 2026 23:22

Merge commit '91a2f6f2776e654ee3ac45c3a5ade1602c09a29c' into codex/ty…

67f8e88

…ped-test-infrastructure

fix: close typed test boundary gaps

ba1d5e1

Merge commit 'a0973148437e429c0cad192a29533271e74996ff' into codex/ty…

c137e56

…ped-test-infrastructure

Merge commit '0cdc326526cd33463938082657198fac941efa1a' into codex/ty…

9c79a36

…ped-test-infrastructure

Merge commit '8968c1f5f7f1e2e2435d66a50338f3b8a1748343' into codex/ty…

689f0d2

…ped-test-infrastructure # Conflicts: # package.json # scripts/check-declarations.ts # test/exact/builtPublicConfig.types.ts # test/exact/sourcePublicConfig.types.ts

HardlyDifficult marked this pull request as ready for review July 12, 2026 07:29

Copilot started work on behalf of HardlyDifficult July 12, 2026 07:29 View session

Copilot finished work on behalf of HardlyDifficult July 12, 2026 07:31

cursor Bot reviewed Jul 12, 2026

View reviewed changes

HardlyDifficult marked this pull request as draft July 12, 2026 08:00

HardlyDifficult added 2 commits July 12, 2026 04:00

Merge commit '1557d19b5ef42e2ec99dd8f875cb72f3fbac347c' into codex/ty…

e819e38

…ped-test-infrastructure

test: make config exactness any-resistant

8b2caa9

HardlyDifficult mentioned this pull request Jul 12, 2026

Validate generated DAML reader payloads #427

Draft

HardlyDifficult marked this pull request as ready for review July 12, 2026 08:16

Copilot started work on behalf of HardlyDifficult July 12, 2026 08:16 View session

Copilot finished work on behalf of HardlyDifficult July 12, 2026 08:20

cursor Bot reviewed Jul 12, 2026

View reviewed changes

HardlyDifficult marked this pull request as draft July 12, 2026 08:41

HardlyDifficult added 6 commits July 12, 2026 09:22

fix: align typed test mocks with runtime

f13f0a6

Merge commit '98d65ded8aed104d2b0af03c119a901fa441ee0c' into codex/ty…

49578de

…ped-test-infrastructure

test: harden package config exactness

3726f80

test: refresh canonical type inventory

cb4c3a5

Merge commit '9352fc7438bcdb50ee066e0e785db9c1a7b823f1' into codex/ty…

4dd4850

…ped-test-infrastructure

test: align schema fixture helper usage

22d8fb1

Uh oh!

Conversation

HardlyDifficult commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Stack

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Reviews paused

Uh oh!

HardlyDifficult commented Jul 10, 2026

Uh oh!

HardlyDifficult commented Jul 10, 2026

Uh oh!

HardlyDifficult commented Jul 10, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 10, 2026

Uh oh!

HardlyDifficult commented Jul 10, 2026

Uh oh!

HardlyDifficult commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026

Uh oh!

HardlyDifficult commented Jul 10, 2026

Uh oh!

Copilot AI commented Jul 10, 2026

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

HardlyDifficult commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HardlyDifficult commented Jul 10, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading