Type OCF manifest extraction end to end

[HardlyDifficult]

Summary

• expose exact canonical OcfTransaction, OcfManifest, and entity-correlated replication contracts from the curated package root
• route manifest reads through the generated-decoder dispatcher and bucket results exhaustively by object_type
• reject duplicate manifest/source identifiers so replication never depends on a silent winner
• make CantonOcfDataMap deeply validated, cloned, frozen, and readonly at its public boundary
• correlate source/create/edit/delete replication unions so each discriminator determines the exact payload type
• keep built-declaration fixtures lint-clean from a fresh checkout before dist exists

Validation

• npm run test:ci — 93 suites / 5,391 tests passed
• npm run test:declarations
• npm run test:package-consumer
• npm run test:exact-public-config
• npm run typecheck
• npm run build
• clean-checkout npm run lint
• npm run format
• CI and OCP QuickStart pass on exact head 9b9d23efda0a21ef20478df44c05ed7acd248b54

Stack

• stacked on Enforce typed test and tooling boundaries #425
• remains draft until its parent reaches the final review gate

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0573b062-6295-497e-be81-1050eb9348f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Note

Reviews paused

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/typed-ocf-manifest

---

_{Comment @coderabbitai help to get the list of available commands.}

[HardlyDifficult]

Current head d42b1a1 is green, merge-clean, unassigned, and thread-free. Advancing to Stage 2 and queuing automated review. CodeRabbit is deferred to the org-wide cooldown and remains queued without a ping.

[HardlyDifficult]

@copilot review

[HardlyDifficult]

cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit d42b1a1. Configure here.}

[Copilot]

@copilot review

Completed review on the current PR diff against codex/typed-test-infrastructure; I did not find any high-confidence actionable issues.

[HardlyDifficult]

Returned to draft because upstream schema-boundary branches #417–#421 have new material fixes that still need to be propagated through this stacked PR. Exact-head CI and Copilot-first bot review will be refreshed after the ordered restack.

[HardlyDifficult]

@coderabbitai pause

[coderabbitai]

✅ Action performed

Reviews paused.

[HardlyDifficult]

Propagated finalized #425 and completed the typed manifest/ordering hardening on exact head e272e9ceaa34dec551334391a0126ded29f0e0b9 using normal merge commits; no history rewrite. Independent audit confirms the #426 delta is byte-identical across the parent refresh. Generic sorting preserves literal/custom fields with code-unit order; all canonical retroactive vesting and result-parent transaction orderings are covered; manifest/data-map diagnostics are bounded and proxy-safe; no retired PlanSecurity behavior remains; the 49-object inventory regenerates byte-identically. Local validation is green: 86 suites / 4,472 tests, 87.49% statements / 78.78% branches / 86.54% functions / 87.71% lines, build, declarations, exact public config, typechecks, lint, formatting, inventory, and diff checks. The PR remains draft/unassigned pending exact-head CI and Copilot-first review.

[HardlyDifficult]

Propagated the finalized #421 review fix into exact head 35614c22a2f56bd32c80f112185dd0a42b29de64 with a normal merge. Audit confirms #426s manifest/sorter/ordering slice retains stable patch ID 633846cd. Full validation is green: 87 suites / 4,473 tests, 87.51% statements / 78.83% branches / 86.49% functions / 87.70% lines, build, declarations, exact config, lint, formatting, deterministic 49-object inventory, transaction-ordering matrix, bounded diagnostics, and diff checks. The PR remains draft/unassigned pending fresh CI and Copilot-first review.

[HardlyDifficult]

@copilot review

Please perform a formal review of exact current head 35614c22a2f56bd32c80f112185dd0a42b29de64. The finalized parent review fix is propagated and independent audit confirms the manifest/sorter/ordering slice retains stable patch ID 633846cd. Build-and-test, the 8m06s QuickStart run, 87 suites / 4,473 local tests, declarations, exact config, lint, formatting, transaction-ordering matrix, deterministic inventory, mergeability, and all threads are clean. Copilot is being requested first for this material revision.

[HardlyDifficult]

Corrected stack propagation is pushed at 5dad9a23b4342915b346968f8a44d7048428bc1a, incorporating exact parent #425 689f0d222214fa658b9395c071956ea27c50702e.

Validation on this exact head:

• full test:ci: 91 suites / 5,326 tests, coverage passing
• focused transaction sorting + replication: 2 suites / 225 tests
• deterministic stress invariant now executes 500 bounded randomized dependency graphs using master seed 0x5eedc0de; each case verifies two seeded permutations, losslessness, and every parent → issuance → action edge, with reproducible case/seed diagnostics
• correlated CantonOcfDataEntry tuple-union setter and narrowed readonly get contracts pass in source and built declarations
• runtime ImmutableMapSnapshot behavior passes: input aliases are detached, returned buckets expose no mutation methods, and replacement snapshots remain isolated
• hardened declaration/package-consumer/cardinality pipeline, clean build, typecheck, exact public config, ESLint, Prettier, and diff checks passing
• source and built inventories agree: 55 canonical variants, 0 aliases, fingerprint 39418162cb257fc316d7a15efc24d825223fac9a9d9d4d2d5104cc53ebb444c0

The PR remains draft and unassigned while fresh CI runs on this material revision. No reviewer requests were made during propagation.

[HardlyDifficult]

Follow-up CI-order fix is pushed at e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6.

The previous exact head exposed a clean-checkout pre-build lint failure: test/declarations/replicationHelpers.types.ts imported absent dist declarations, causing the explicitly written OcfStakeholder | OcfStockClass to become two error-types and trigger no-redundant-type-constituents before build. The declaration contract now derives that widened bucket as CantonOcfDataEntry<"stakeholder" | "stockClass">[1]. This keeps the independent key/data cross-product rejection intact without weakening lint rules.

Exact validation:

• reproduced the failure after npm run clean
• with dist still absent, npm run fix passes and leaves the worktree diff byte-for-byte unchanged
• post-build declaration compilation passes, proving the correlation @ts-expect-error is still consumed against real emitted types
• hardened declaration/package-consumer/cardinality pipeline passes
• full test:ci: 91 suites / 5,326 tests, coverage passing
• source and built inventories: 55 variants, 0 aliases, matching fingerprint 39418162cb257fc316d7a15efc24d825223fac9a9d9d4d2d5104cc53ebb444c0
• typecheck, ESLint, Prettier, and diff checks pass

The PR remains draft and unassigned while fresh CI and QuickStart rerun. No reviewer requests were made.

[HardlyDifficult]

@copilot review

Please review exact current head e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6. Pre-review gate: both required checks are successful, GitHub is CLEAN/MERGEABLE, the PR is unassigned, and zero review threads are unresolved. Focus on typed OCF manifest boundaries, exact entry discriminators, trap-safe validation, and public declaration parity. Report every actionable current-head issue before the other reviewers.

[Copilot]

@copilot review

Please review exact current head e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6. Pre-review gate: both required checks are successful, GitHub is CLEAN/MERGEABLE, the PR is unassigned, and...

Completed review on exact head e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6 against codex/typed-test-infrastructure; I did not find any high-confidence actionable issues. I also verified recent CI and Test OCP CN-Quickstart Integration workflow runs are successful on both codex/typed-test-infrastructure and codex/typed-ocf-manifest.

[HardlyDifficult]

@copilot review

Retrying the required exact-head gate for e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6; the first request received no explicit response. The PR remains green, CLEAN/MERGEABLE, unassigned, and has zero unresolved threads. Please provide actionable findings or an explicit no-findings response for this exact revision before Cursor and CodeRabbit.

[HardlyDifficult]

@cursor review

Please review exact current head e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6. Copilot completed its required exact-head pass with no actionable findings: #426 (comment). Both required checks are green, GitHub is CLEAN/MERGEABLE, and zero review threads are unresolved. Focus on typed OCF manifest boundaries, exact entry discriminators, trap-safe validation, and public declaration parity.

[Copilot]

@copilot review

Retrying the required exact-head gate for e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6; the first request received no explicit response. The PR remains green, CLEAN/MERGEABLE, unassigne...

Completed exact-head review for e54dbe3d36e303e87dd6d18ebafeec4bedee9ef6 against codex/typed-test-infrastructure and I did not find any high-confidence actionable issues. I also verified required exact-head workflow runs are successful (CI and Test OCP CN-Quickstart Integration) on both the stacked base branch and this PR branch.

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e54dbe3. Configure here.}

[HardlyDifficult]

Upstream PR #425 advanced materially with corrected #424 integration and any-resistant source/built/package exactness guards. Returning this stacked PR to draft while I propagate exact parent 8b2caa991c0ad8ace14edaf8f00bb4c811eaf0c2, validate the integrated tree, and rerun exact-head reviewer gates.

[HardlyDifficult]

Final audited parent integration is pushed at cd3e7dabe494b86b17a0ee1ded20456616650ab0. The inherited replication regression now uses the canonical nominal CantonOcfDataMap constructor and typed Stakeholder fixture, preserving #426’s correlated manifest contract instead of weakening it; manifest production/runtime/declaration code is otherwise unchanged.

Independent validation is green: targeted 6 suites / 316 tests; full test:ci 91 suites / 5,331 tests; clean build/declarations/inventory/exact-public/built-cardinality/package-consumer; typecheck; lint; formatting; ancestry and diff checks. This PR remains draft and unassigned while fresh remote CI runs; Copilot will be requested first on the new exact head.

[HardlyDifficult]

Exact head cd3e7da is merge-clean, unassigned, thread-free, and green in both build-and-test and the full OCP QuickStart integration. Advancing to Stage 2.\n\n@copilot review\n\nPlease perform the first exact-head substantive review, focusing on the nominal CantonOcfDataMap boundary, rejection of plain Map impostors and malicious iterables, declaration precision, and preservation of the full inherited validation stack. Cursor will be requested after your response.

[HardlyDifficult]

Returned to draft because upstream #417 received a material exact-head corrective revision after full CodeRabbit review. This stacked PR will remain held until the audited #417 head and each intervening parent are propagated normally; fresh CI and Copilot-first reviewer gates are required afterward.

[HardlyDifficult]

Fresh-checkout CI exposed a declaration fixture that only linted after dist existed. The fixture now derives its widened value type through the exported entity mapping instead of directly unioning unresolved built types. Clean-checkout lint, full tests, declarations, build, package-consumer, exact-public-config, and formatting all pass; hosted CI is rerunning on exact head 9b9d23efda0a21ef20478df44c05ed7acd248b54.