Repository navigation
Retain typed failure custody for refused board-v2 migration-prepare - #4812
Merged
Merged
Conversation
MigrationPrepare previously wrote only its prepared report on success; a refusal returned exit 3 while the shared stderr pointed callers at private invocation evidence that never existed for prepare (#4730 finding). Once prepare owns a new report path, any refusal now writes a private 0600 REPORT.prepare-failure.json with the stage, bounded failure code, typed error class and allowlisted reason, exception type name only, report presence and the injected-clock time. Messages, paths and response bytes are not copied. A pre-existing failure record refuses the new preparation unchanged. No retry, apply or readback semantics change. Refs #4730 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lure custody in the signature Review of 1860ef6: the /// comment on a private binding in an implementation file with a sibling .fsi failed signature-doc-siting. Also pin zero native reads for unowned prepare refusals, including a directory at the report path. Refs #4730 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4730. This is a source-only correction for the #4730 process finding. It doesn't close the Outcome.
Problem
board-v2 migration-preparewrote its prepared report only on success. Failure custody (terminal.json) exists only formigration-apply. A prepare refusal returned exit 3 with the shared stderr "inspect private original invocation evidence", but no such evidence existed. During #4759 this left the original prepare refusal's cause Unknown.Change
0600REPORT.prepare-failure.json(fs.gg.board-v2.migration-prepare-failure/1). It records:stage(scope-read,scope-parse,executing-identity,native-preparationorprepared-report-write);failureCode;errorClassand the existing allowlistedreason(migrationFailureReason);preparedReportPresent;failedAtfrom the injected clock;nativeMutationDispatched:falseandautomaticRetry:false.tests/coord-board-v2-cli-join/INSPECT.mddocuments the record.Evidence
runMigrationWithConnectionpath: transport refusal; drift between the two stable collections; an unexpected read exception (its private message is not copied); success, and the unowned/collision refusals. All 3 fail on the base and pass here.coord-board-v2-cli-join: 78/78 passed locally;tests/signature-doc-siting/run.sh90/90 after the review repair (the///on a private binding became//; the prepare-failure output is documented in the.fsi).Limit. If the report's parent directory isn't private, the private-write rule also blocks the failure record. That case still yields only exit 3.
Not done. Packaging, publication and installed caller adoption remain separate, under their own release route.
🤖 Generated with Claude Code