Repository navigation
Recover a known legacy PR roster through guarded canonical lane adoption #5264
Description
Work level: Delivery · Track: Active delivery · Intended Status: Done
Owner
Root/fdev integrates; /root/or_5245 owns the canonical lane-tool repair. Existing Rendering PR1505 and1492 retain their source owners and exact identities.
Done when
The maintained PR-lane adapter can safely adopt the existing known two-legacy-PR roster without bypassing its two-PR capacity, single-chain, exact-head, preimage, metadata-preservation or no-resend controls. Currently adopting either Rendering1505 or1492 refuses because the other lacks lane metadata, so neither single-PR ordering can succeed. Provide a bounded explicit known-roster recovery route with complete fresh population validation and exact per-PR campaign/chain/head assignments, including guarded partial-effect/readback handling. Missing/extra/changed/ambiguous reservations, invalid identities, stale heads and duplicate chains remain refused; no SC2 exception is generalized silently.
Also resolve legitimate initial delivery-continues declaration for these legacy PRs through an explicit supported metadata operation, preserving every unrelated machine marker and rejecting arbitrary caller injection. Inspect existing routes before adding capability; use an existing supported route if it already satisfies this.
Add meaningful positive/negative and uncertain/partial-effect controls, independently review exact source, run required CI and merge normally. Use the accepted adapter once to adopt the two original PRs and independently verify their heads, bodies, lane identities and complete roster. No replacement PR, direct raw metadata bypass, source rewrite, merge or release is implied. Actual source changes remain under#5213 and#5238.
Current deliverable
Accepted protected sourcef3798576 and two confirmed guarded native adoptions, independently read back by Root. Acceptance #5264 (comment).
Next action
None in this completed recovery Delivery. Existing source owners resume#5213/PR1505 and#5238/PR1492 with their verified lane identities.
Blocked on
None for this accepted metadata recovery. The pre-existing1492 moved-base source failure remains with#5213/#5238.
Acceptance evidence
Original no-effect refusals: /home/developer/.fsgg-scratch/5213/lane-inspect.json and /home/developer/.fsgg-scratch/5238/evidence/1492-adoption-inspect.json. Native affected PRs: FS-GG/FS.GG.Rendering#1505 and FS-GG/FS.GG.Rendering#1492.
Activity
EHotwagner commentedon Nov 2, 2026
EHotwagner commentedon Nov 2, 2026
Root acceptance, 2026-11-02: #5264 is complete. Source PR #5266 mergedf3798576248040a1afb2072c7b53c32572aaf6b4 at21:38:16UTC; Root independently verified current main and treec31695 against reviewed116bcf4d and genuine tested-checkout artifact13179459495. Independent source review passed. The maintained controls printed49 tests/OK (38 existing plus11 new, with the targeted custody rerun counted only once); all37 original workflows passed on attempt1, with52 successful checks/three intentional skips.
Actual guarded adoption used that accepted protected helper and one fresh retained custody state: exactly two confirmed PATCHes, first Rendering1492 then1505, with independent full-roster/head/body readback after each. Root separately reread both native PRs and the complete two-PR population. Heads13728f66 and97024756, titles, IDs/node IDs, branches/bases, state and draft flags remain unchanged. All original prose and machine-marker values are preserved; the canonical writer moved1492's existing routine marker to the metadata block without changing its value. Each now has exactly one continues declaration and its distinct reviewed lane identity under campaign outcome-led-programme-20261016. No source push, merge, tag or publication occurred in this adoption. The original custody is complete; no uncertain effect was replayed.
The four expected edited-event workflows ran. Three succeeded;1492's routine check retained the already-owned old-producer moved-base refusal (old event basecd2ccd versus current2d35). That source defect remains#5213/#5238, and does not turn two independently confirmed metadata effects into an unperformed adoption. No workflow was rerun. The initial Root prefix-only readback assertion was too strict about canonical marker placement; corrected comparison independently preserves all prose and marker values, with the original checker failure retained.
The actual two-PR deadlock is resolved. #5213 now resumes its existing1505 source branch; #5238 retains1492 and the now-declared chain rendering-5238-actual-callability. Delivery source and reusable Atlas lesson are in acceptedf379. Broader Rendering source/runtime acceptance remains with those owners and dependency#1507.