Skip to content

Owner briefs carry the reviewers' standard adversarial checks; dispatch names shared-type owners #5239

Closed

Description

@EHotwagner

Parent Outcome: #5097
Work level: Delivery · Track: Active delivery · Intended Status: In progress

Owner

The Root/fdev skills owner (same owner as #5185).

Done when

From the 2026-11-02 progress report (docs/reports/progressReports/2026-11-02-060416Z-unified-v3-progress.md), process problems 2 and 3. Defects kept being found by independent critics rather than by the authors' own checks: SDD#1158 partial apply, Algorithms#6 A* inadmissible, Algorithms#7 publish route, Game#802 ring contrast, Game#797 sizing regressions. Two parallel owners also built rival Theme types (Game#802, Game#805).

  1. pnext-item (both skill roots) gains a short pre-review self-check the owner runs before requesting review:

    • Range: fuzz or property-test across the full range the API accepts, not only typical values.
    • Partial failure: for every multi-step write or effect, ask what happens on failure or kill between steps, and test it.
    • Planted bugs: disable each safety check or guard and confirm a test fails.
    • Reviewer probes: when repairing after a review, re-run all of the reviewer's probes against the new head, and add the reviewer's probe classes to their own tests.
    • Cross-cutting fixes: for a cross-cutting defect (sizing, concurrency, lifecycle), write the invariant first, then the code, not point fixes.

    Keep it concise, about 10 lines; no new gate, no new review chain.

  2. Dispatch guidance (work-board-coord and/or intra-repo-parallel-work, both roots): when parallel Deliveries share a type, contract or file, the dispatch brief names the single owner of that shared surface, and the others consume it.

  3. Parity and checks: skill-view parity holds and the skill checks pass, with a CHANGELOG entry.

Current deliverable

None.

Next action

Dispatch the skills owner.

Blocked on

Nothing.

Acceptance evidence

None yet.

Refs #5097

Activity

  1. EHotwagner commented on Nov 2, 2026

    @EHotwagner
    ContributorAuthor

    Accepted #5239 source delivery on 2026-11-02 via PR #5241, reviewed head f1bda93073bbfe9f3ef1e7b5a6e3fac4b8bccb17, merged as b8a444ee9ae7bef535adfcb39445577bcf0feb4e. The short owner self-check, explicit shared-surface ownership guidance, both-root parity and changelog acceptance are satisfied. Independent source review and canonical integration passed; see #5241 (comment) .

    Original exact-candidate semantic generators printed:

    routine-delivery board mutate: 73/73 mutants killed
    skill-quality fixture: all 60 rejection cases passed
    

    The original full canonical run exited 0 in 9m12.810s under 1 CPU / 2 GiB, with all compiled predecessor fixtures passing. Skill parity reports 29 ids / 2 roots; the prior exact-source review verified both roots and generated manifest/census consistency. Required hosted checks passed. The historical hosted semantic cancellation remains cancelled; the independent bounded local run supplies its missing semantic result without altering workflow policy.

    This Delivery has no publication/install clause. Coherent version 0.114.4 is source preparation only; canonical publication remains separately owned. Broader process issue #5185 and standing parent Outcome #5097 remain open for their own assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions