Code crashes if selected auto DNE o(*°▽°*)o - #297
Closed
Wu-Fan-529 wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens autonomous selection to prevent failures when the dashboard-selected auto routine no longer exists, by falling back to a “do nothing” command.
Changes:
- Promotes the “Do Nothing” command to a
RobotContainerfield so it can be reused as a consistent fallback/default. - Updates
getAutonomousCommand()to return “Do Nothing” whenautoChooser.getSelected()isnull.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public String pathString = ""; | ||
| public Pose2d pathStartPose = new Pose2d(); | ||
| public Pose2d pathEndPose = new Pose2d(); | ||
| Command DoNothing = Commands.none(); |
|
|
||
| public Command getAutonomousCommand() { | ||
| return autoChooser.getSelected(); | ||
| return autoChooser.getSelected() == null ? DoNothing : autoChooser.getSelected(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.