Base autos (//▽//) - #81
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the robot’s Choreo autonomous library by adding multiple “Preview” trajectories and regenerating the associated Java constants/trajectory registry so the code can reference these paths consistently at runtime.
Changes:
- Regenerated
ChoreoVarswith additional Choreo variables (typed units) and a larger set of named field poses. - Regenerated
ChoreoTrajwith new trajectory constants and updatedALL_TRAJECTORIESlookup entries. - Added/updated multiple Choreo
.trajfiles and updated_all_paths.chorvariable/pose definitions (including bumper dimension updates).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/frc/robot/constants/ChoreoVars.java | Adds generated Choreo variables (typed units) and many named poses used by trajectories. |
| src/main/java/frc/robot/constants/ChoreoTraj.java | Adds new generated trajectory constants and registers them in ALL_TRAJECTORIES. |
| src/main/deploy/choreo/PreviewSecondDSideTrenchNeutral.traj | Adds a new D-side trench-to-neutral preview trajectory definition. |
| src/main/deploy/choreo/PreviewPreloadOnly.traj | Renames the path and updates parameters for a preload-only trajectory placeholder. |
| src/main/deploy/choreo/PreviewPreloadAndBackup.traj | Adds a new preview preload-and-backup trajectory definition. |
| src/main/deploy/choreo/PreviewOSidePreloadAndBackup.traj | Adds a new O-side preview preload-and-backup trajectory definition. |
| src/main/deploy/choreo/PreviewFirstOSideTrenchNeutral.traj | Adds a new O-side trench-to-neutral preview trajectory definition. |
| src/main/deploy/choreo/PreviewFirstDSideTrenchNeutral.traj | Adds a new D-side trench-to-neutral preview trajectory definition. |
| src/main/deploy/choreo/AutoPIDTuning.traj | Updates bumper dimensions in the PID tuning trajectory config. |
| src/main/deploy/choreo/_all_paths.chor | Adds shared expressions/poses and updates bumper dimensions used across Choreo paths. |
Suppressed comments (1)
src/main/java/frc/robot/constants/ChoreoVars.java:18
- New constants in this file use lower_snake_case (e.g.,
against_hub), which conflicts with the project’s established constants naming convention (SCREAMING_SNAKE_CASE) for fields inconstants/. Consider renaming these generated constants (or adjusting Choreo codegen settings) so Java code can reference them in the expected style.
public static final Pose2d against_hub = new Pose2d(3.5825274, 4.0294271, Rotation2d.fromRadians(0));
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: BrodyKarr <145169276+BrodyKarr@users.noreply.github.com> Co-Authored-By: jayden mendoza <244560677+jaymendo670-png@users.noreply.github.com> Co-Authored-By: Justinpham17386769 <244249272+Justinpham17386769@users.noreply.github.com> Co-Authored-By: Tej shah <187054380+Tejshah88@users.noreply.github.com> Co-Authored-By: lameesnotlame <258483139+lameesnotlame@users.noreply.github.com>
Closed
TaylerUva
enabled auto-merge (squash)
August 9, 2026 01:10
TaylerUva
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.