[No QA][Payment due @ahmedGaber93] Docs updates for E/A#97998 document 500-expense per-report move limit - #98684
Conversation
Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://915c69ba.helpdot.pages.dev ⚡️ Updated articles: |
|
Nothing to fix here — all real CI checks are green. ✅ The only check still showing red is Check independent approval, and that's not a code or CI failure. It fails by design until an independent internal reviewer approves the PR, so there's no fix I can push for it — it clears once someone approves. Current check status
Everything else is either passing or skipped. This is a docs-only PR, and the earlier |
|
@MelvinBot Mark this PR ready for review |
|
🤖 Done — this PR is now marked Ready for review. Since it's a docs-only change (a single help-site markdown file), no app testing was needed. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🎯 @ahmedGaber93, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes small, additive edits to the existing Managing Expenses in a Report article to document the new 500-expense per-report move limit (companion to #97998). No new headings, metadata, or structural changes are introduced. The additions slot into the existing, compliant "How to Move or Remove Expenses from a Report" section and the "Why can't I move, edit, or delete expenses in a report?" FAQ. The changes are accurate, well-scoped, and align with the source PR's blocking behavior. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed diff, not unchanged portions of the article. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d52af7565b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.4.56-0 🚀
|
Explanation of Change
Companion help-site update for #97998, which surfaces a warning and blocks moving an expense into a report that has already reached the 500-expense per-report limit (the modal reads: Reports are limited to 500 expenses. Please move some to another report.).
Previously, the Managing Expenses in a Report article documented how to move expenses between reports but did not mention the 500-expense limit anywhere. This PR documents that limit so the new blocking behavior is discoverable in help.
Changes
Guidelines applied
Reviewed and applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. Changes are additive edits to an existing, compliant article: UI labels (Move expense(s), Remove from report, Create report) match the existing article and the app, no new headings were introduced, and the user-facing message is quoted verbatim from the source PR.Related
@ahmedGaber93, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.