Skip to content

[No QA] Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app - #98216

Open
MelvinBot wants to merge 4 commits into
mainfrom
melvin-docs-personal-karma-native-91837
Open

[No QA] Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app#98216
MelvinBot wants to merge 4 commits into
mainfrom
melvin-docs-personal-karma-native-91837

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

E/A#97177 disables the Enable Personal Karma toggle in the Expensify mobile app (iOS and Android). On native, tapping the toggle previously opened a "Not here" page instead of the Add payment card flow (E/A#91837), so it's now disabled and shows the subtitle "Manage your personal karma preferences from web." On web and mobile web the toggle still works and opens the Add payment card flow.

This updates the help site to reflect that Personal Karma can only be managed in a web browser.

Files updated

  • docs/articles/new-expensify/settings/Personal-Karma.md — added a web-only note to the enable and disable sections, and corrected the menu label to Save the world (matching the live UI).
  • docs/articles/new-expensify/billing-and-subscriptions/manage-your-subscription-and-billing/manage-billing/Manage-Personal-Karma-and-Corporate-Karma.md — added a web-only note to the enable/disable section and pointed navigation at the web browser.

Verification

  • Live web UI confirmed (dev NewDot): the AccountSave the world menu item, the Enable Personal Karma toggle, and its description "Donate $1 to Expensify.org for every $500 you spend each month" all match. Toggling it on web opens the Add payment card right-hand panel.
  • Source PR: on native (index.native.ts) the toggle returns true for disabled with the managePreferencesFromWeb subtitle; on web/mweb (index.ts) it returns false.

@nkdengineer, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: nkdengineer <nkdengineer@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 10, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app [No QA] Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app Aug 10, 2026
@OSBotify

This comment has been minimized.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only red check here is Check independent approval, and there's nothing to fix in the code — it's the merge gate that stays failing until a human reviewer approves the PR, not a build/test failure. Every other check passes.

Check breakdown
  • check, dryRun, spellcheck, validate, verify, verifySignedCommits, CLA — all passing
  • build (Deploy ExpensifyHelp) — all build/deploy steps succeeded; it's only in runner cleanup and will go green
  • Check independent approval — requires an independent reviewer's approval; expected to be red until the PR is reviewed

To move this forward, nkdengineer (or another reviewer) just needs to review and approve — no push from me is needed.

@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review August 18, 2026 06:18
@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

@neil-marcellini @RachCHopkins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@melvin-bot
melvin-bot Bot removed the request for review from a team August 18, 2026 06:18
@MelvinBot

Copy link
Copy Markdown
Contributor Author

There's nothing to fix here — no code check is failing.

The only failing check is Check independent approval, which is not a code failure. It fails simply because the PR hasn't yet received an independent human review approval. It will clear on its own once nkdengineer (or another reviewer) reviews and approves.

Every other check is passing (spellcheck, verify, validate, check, dryRun, validateSchemas, etc.); review is still in progress. This is a docs-only PR, so no code fix is needed and I did not push anything.

Next step: nkdengineer, please review the two updated .md files and approve — that's what will clear the remaining check.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR reflects that Personal Karma can now only be managed in a web browser (the toggle is disabled in the native mobile app per E/A#97177). It does three things: (1) deletes the standalone settings/Personal-Karma.md article, (2) adds a redirect from the old URL to the surviving Manage-Personal-Karma-and-Corporate-Karma.md article, and (3) edits the enable/disable section of the surviving article to state the web-only limitation and drop the mobile navigation. Consolidating two overlapping Personal Karma articles into one and redirecting the old URL is the right call and aligns with the "one primary workflow per article" principle. The functional intent is correct; the main gaps are in exact navigation phrasing and minor formatting.

Scores Summary

  • Readability: 8/10 - The new note is clear and the numbered steps remain sequential and action-oriented. Slightly weakened by trailing whitespace on several added lines and an "On web:" label that is now redundant since mobile management no longer exists.
  • AI Readiness: 8/10 - The surviving article already has strong YAML metadata (title, description, keywords, internalScope) and correct heading hierarchy (# / ## only). The added web-only sentence reinforces retrieval intent. No new headings were added by the diff, so hierarchy is unaffected.
  • Style Compliance: 6/10 - The Account and Save the world references and bolded toggle/section names are correct. However, the new navigation phrasing does not fully follow the naming conventions: when a feature is not available on mobile, the guidelines prescribe the explicit statement "This feature is not available on mobile," and the removed unified "(on the left on web, on the bottom on mobile)" pattern should be replaced with a clean web-only instruction rather than an "On web:" prefix plus a lone left-nav step.

Key Findings

  • Positive: Correct consolidation of duplicate Personal Karma content into a single article, with a proper redirects.csv entry preserving the old URL. This improves retrieval precision.
  • Positive: UI labels corrected to match the live product (Save the world, Enable Personal Karma section, Account tab) with proper bold formatting and Sentence case.
  • Issue: The web-only limitation is phrased as "Personal Karma can only be managed in a web browser." The naming conventions call for the explicit sentence "This feature is not available on mobile." Consider stating the limitation in that prescribed form for consistency and determinism.
  • Issue: Trailing whitespace on the added lines ("web browser. ", "On web: "). Clean these up.
  • Minor: The "On web:" prefix is slightly awkward given there is no longer a mobile path in this section. Either drop the prefix (single web-only flow) or keep a clear, explicit web-only lead-in sentence.

Recommendations

  • Replace or supplement "Personal Karma can only be managed in a web browser." with the prescribed "This feature is not available on mobile." phrasing, or combine both so the limitation is unambiguous.
  • Remove trailing whitespace from the added lines.
  • Since the section is now web-only, drop the redundant "On web:" label and let the numbered steps stand, or lead with a single explicit web-only sentence.
  • Confirm the section heading "How to enable or disable Personal Karma" still accurately scopes the content now that mobile is excluded (it does, and remains task-based and compliant).

Files Reviewed

  • docs/articles/new-expensify/billing-and-subscriptions/manage-your-subscription-and-billing/manage-billing/Manage-Personal-Karma-and-Corporate-Karma.md - Modified enable/disable section; correct intent, minor navigation-phrasing and whitespace issues.
  • docs/articles/new-expensify/settings/Personal-Karma.md - Deleted; appropriate consolidation into the surviving article.
  • docs/redirects.csv - Added redirect from the deleted article's URL to the surviving article; correct.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 316fe9cecf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott
stephanieelliott removed the request for review from neil-marcellini August 18, 2026 06:25
@stephanieelliott stephanieelliott self-assigned this Aug 18, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No fix is needed — all substantive checks are passing.

The only remaining "failing" check is Check independent approval, which isn't a code failure. It fails only because the PR hasn't yet received an independent human review approval. It will clear on its own once nkdengineer (or another reviewer) reviews and approves the PR.

Current check status
  • build (Deploy ExpensifyHelp) — passed
  • checklist, spellcheck, verify, validate, validateSchemas, verifySignedCommits, actionlint, check, dryRun, CLA — all passing
  • Check independent approval — waiting on an independent review approval (not fixable via a code push)

This is a [No QA] docs-only PR touching two .md files, so there is nothing in the diff that a code change could fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants