fix: disable enable personal karma on native - #97177
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Didn't test an adhoc but the testing steps LGTM
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
aimane-chnaif
left a comment
There was a problem hiding this comment.
@nkdengineer please pull main and add el copy (new Greek language was added recently)
|
@mountiny Please run translation workflow. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.52-0 🚀
|
|
Reviewed — yes, help site changes are required. This PR disables the Enable Personal Karma toggle in the mobile app (iOS/Android) and directs users to manage it from web, but the help site still tells members they can enable/disable Personal Karma on mobile. I opened a draft docs PR to fix that: 📝 #98216 — Docs updates for E/A#97177 Personal Karma web-only, disabled in mobile app What changed in the docs:
Files:
@nkdengineer, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
fix: disable enable personal karma on native
Fixed Issues
$ #91837
PROPOSAL: #91837 (comment)
Tests
Manage your personal karma preferences from webis displayed below the toggleOffline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-28.at.10.39.23.mov
Android: mWeb Chrome
Screen.Recording.2026-07-28.at.10.40.10.mov
iOS: Native
Screen.Recording.2026-07-28.at.10.39.51.mov
iOS: mWeb Safari
Screen.Recording.2026-07-28.at.10.40.36.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-28.at.10.40.53.mov