-
Notifications
You must be signed in to change notification settings - Fork 4k
[HOLD 91300] Support Validation_Failed bank account
#97962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dominictb
wants to merge
55
commits into
Expensify:main
Choose a base branch
from
dominictb:feat/support-validation-failed-bank-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+649
−15
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
2ce68c7
Add Validation_Failed state
dominictb 2190814
Add NOC code constants
dominictb 94b144b
Add terms
dominictb 5357409
Add lastNocCode to types
dominictb ea2d771
Add NOC code helper
dominictb 6ba314f
Add support for Validation_Failed connection status
dominictb f23b343
Update getBankAccountConnectionStatus usage in PaymentMethodList
dominictb 9296371
Update getBankAccountConnectionStatus usage in WorkspaceWorkflowsPage
dominictb 836e974
Update getBankAccountConnectionStatus usage in test
dominictb b02a655
Fix spellcheck
dominictb 8bf4771
Run generateTranslations script
dominictb c76f360
Initialize FixBankAccountPage
dominictb 6f3c380
Add type definition for ResendFailedValidationAmounts command
dominictb 73c4d55
Add ResendFailedValidationAmounts command
dominictb 9aa2671
Add translation terms for FixBankAccount page
dominictb 450bf4d
Run generateTranslations script
dominictb ea4c06a
Update translation style
dominictb 25f3484
Run generateTranslations script
dominictb ee2b6d1
Show success state
dominictb 9a28b08
Show insufficient funds error
dominictb bb05812
Show debit blocked error
dominictb 356a6ae
Only show RBR for insufficient funds and debit blocked error
dominictb 7d34fdf
Expose requiresFixHandler
dominictb 1ec0b51
Navigate to FixBankAccountPage on tapping Fix
dominictb 28ac5f4
Navigate to FixBankAccountPage from workspace workflows page
dominictb e92eae2
Update route entry point
dominictb 7bb4f38
Navigate to FixBankAccountPage from payment flow
dominictb d869204
Update success text style
dominictb 380b9d4
Remove HTML from insufficientFundsBody
dominictb 98cdc20
Do not use HTML for insufficient funds error
dominictb 54fae1b
Optimistically set data in action
dominictb a5c3408
Show loading indicator
dominictb 5464c03
Fix lint
dominictb 691d159
Add illustrations
dominictb 4fa0ea7
Replace illustrations in FixBankAccountPage
dominictb 5aa710c
Compress SVG
dominictb 4436708
Add English generic error message
dominictb d11a2d7
Run generateTranslations script
dominictb 4988ac7
Show generic error message for other NOC codes
dominictb ee1d8b0
Merge branch 'main' of github.com:dominictb/App into feat/support-val…
dominictb bb4299b
Enfore bankAccountID param as string
dominictb d6a7e67
Add selector for bankAccountList
dominictb 0a81354
Remove displayName from FixBankAccountPage
dominictb fac8f27
Do not navigate if methodID is undefined
dominictb 9ea10a6
Do not navigate if methodID is undefined
dominictb 261e021
Enfore bankAccountID param as string
dominictb e5f950d
Add tests for resendFailedValidationAmounts action
dominictb ecfd884
Add tests for hasInsufficientFundsError and hasDebitBlockedError utils
dominictb ab64da9
Remove redundant br in translations
dominictb d128ae5
Render error message above submit button
dominictb 9bb53f2
Fix double back button
dominictb e012eff
Fix mismatch button paddings
dominictb f81112c
Fix lint
dominictb 7f7c72d
Fix test
dominictb 7b60721
Fix error message pushes main content
dominictb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.