[No QA] Docs updates for E/A#94669 Spend page total spend currency selector

[MelvinBot]

Explanation of Change

Documents the currency selector on the Spend page total spend footer, matching the behavior shipped in #94669.

The footer's Total spend amount can be converted into a different currency via a searchable currency picker (with Apply and Reset). Conversion works whether or not rows are selected:

• With nothing selected, it converts the total for the whole search result.
• With individual expenses selected, it converts their total — even for expenses on a later page after scrolling.
• With reports selected, it converts the reports' total.
• In grouped searches, it converts the grand total or the totals of the groups you select, and supports mixing a whole group with individual expenses from another group.

The picker is disabled only while offline or while the totals are loading (converting requires a refresh from Expensify).

Background

This documents the re-implemented feature. The original #90777 was reverted in #94562 and re-implemented in #94669 (merged 2026-07-30) on a dedicated GetTransactionsConvertedAmount read command, which removed the previous limitations that disabled the picker for grouped rows and out-of-page selections.

Changes

Updated docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md:

• Added a new section How to change the currency of the total spend on the Spend page covering what the footer shows, how to change the currency (with nothing selected or with any selection), the supported selection types (nothing selected, individual expenses, reports, grouped searches), and the only two cases where the picker is disabled (offline and totals loading).
• Added an FAQ entry: Why can't I change the total spend currency?
• Expanded the article keywords for retrieval.

Related

• App PR: [Payment due @ahmedGaber93] Convert Search footer totals via GetTransactionsConvertedAmount command #94669
• Issue: https://github.com/Expensify/Expensify/issues/634354

---

@c3024, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

[c3024]

@MelvinBot merge main branch into this branch

[MelvinBot]

🤖 Merged main into this branch. ✅

There was one merge conflict in docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md, which I resolved by keeping both changes:

• This branch's new "How to change the currency of the total spend on the Spend page" section, and
• The "# Filters" section added on main.

They were non-overlapping additions at the same location, so both are preserved. The PR now shows as mergeable.

[c3024]

@MelvinBot The feature this documents shipped differently. #90777 was reverted in #94562 and re-implemented in #94669, which merged on 2026-07-30. Please update this PR to match the behavior in #94669:

1. The currency picker is no longer disabled for grouped row selections. Grouped searches convert the grand total and selected groups, including mixed selections of groups and individual expenses.
2. The picker is no longer disabled when the selection includes expenses beyond the first page. Out-of-page selections convert correctly.
3. The total converts with nothing selected too, covering the whole search result.
4. The picker is still disabled while offline and while totals are loading, so keep those two cases.
5. Rewrite the "When the total spend currency picker is disabled" section and the "Why can't I change the total spend currency?" FAQ accordingly, and update the title and body to reference [Payment due @ahmedGaber93] Convert Search footer totals via GetTransactionsConvertedAmount command #94669 and drop the feature hold.

[MelvinBot]

Updated the docs and PR metadata to match the behavior shipped in #94669. 🚀

Doc changes (Getting-Started-with-the-Spend-Page.md):

• Grouped selections no longer disable the picker — documented that grouped searches convert the grand total or selected groups, and that you can mix a whole group with individual expenses from another group.
• Out-of-page selections no longer disable the picker — documented that individual-expense selections convert even when some expenses are on a later page.
• Nothing selected now converts the total for the whole search result — added to the intro, footer description, step 1, and the selection-types list.
• Kept the two remaining disabled cases — offline and totals loading — in both the "When the total spend currency picker is disabled" section and the FAQ.
• Rewrote the disabled section and the Why can't I change the total spend currency? FAQ accordingly.

PR metadata:

• Title/body now reference [Payment due @ahmedGaber93] Convert Search footer totals via GetTransactionsConvertedAmount command #94669 (with a note that [Payment due @ahmedGaber93] Add currency selector to Search footer total spend #90777 was reverted in [CP Staging] Revert "Add currency selector to Search footer total spend" #94562 and re-implemented in [Payment due @ahmedGaber93] Convert Search footer totals via GetTransactionsConvertedAmount command #94669).
• Dropped the [Hold for feature] tag from the title since [Payment due @ahmedGaber93] Convert Search footer totals via GetTransactionsConvertedAmount command #94669 merged on 2026-07-30.

⚠️ I could not verify this in a browser this run (web browser control was unavailable), so I confirmed the behavior from PR #94669's description and test plan rather than a live check. Please review the diff and confirm it reflects the current behavior, then mark the PR Ready for review.

[MelvinBot]

There's nothing to fix in the code — every real CI check is passing (build, check, dryRun, spellcheck, validate, verify, verifySignedCommits).

The only failing check is Check independent approval (its Verify peer review step). That's a process gate, not a code failure: it stays red until an independent reviewer approves this PR. It can't be resolved by a commit — it clears once someone other than the author reviews and approves.

Next step is just to get a review/approval. Once this is marked Ready for review and an independent reviewer approves, that check will pass.

Note: I couldn't verify anything in a browser this run (web driving was unavailable), but this is a docs-only PR and the conclusion is based entirely on the CI check results above, so that doesn't affect the analysis.

[c3024]

@MelvinBot mark the PR as ready for review.

[MelvinBot]

Done — marked this PR as ready for review. ✅

[github-actions]

Heading hierarchy violation: This adds another top-level # heading. Per HELP_AUTHORING_GUIDELINES (Sections 4 and 9), an article may have exactly one # heading (the title) plus an optional # FAQ — all other content sections must use ##. Change this to ## How to change the currency of the total spend on the Spend page.

[MelvinBot]

Fixed in fdb1713 — changed this to ## How to change the currency of the total spend on the Spend page and demoted its sub-sections to ### so nesting is preserved. The diff no longer introduces a new top-level # heading.

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR documents the new Total spend currency selector on the Spend page (matching #94669). It adds one instructional section, one FAQ entry, and expands the article keywords. The added content is clear, accurate, well-structured at the second-level heading, and uses task-based headings. The main governance issue is structural: the diff introduces an additional top-level heading, which conflicts with the single-H1 rule in the authoring spec.

Scores Summary

• Readability: 9/10 - The new section is clear, scannable, and well-formatted. Steps are sequential and action-oriented, bolded labels aid scanning, and the selection-type bullet list is easy to parse. Minor: the FAQ answer is dense and packs multiple ideas into one paragraph.
• AI Readiness: 7/10 - Strong task-based headings (How to change..., What the... shows, When the... is disabled), full feature names, and expanded keywords for retrieval. Deductions: the added heading "How to change the currency of the total spend on the Spend page" is a second top-level heading, violating the "exactly one # heading (plus optional # FAQ)" rule (Section 4/9); it should be demoted to a second-level heading. The article also still lacks the mandatory internalScope frontmatter field (the diff edits frontmatter but does not add it).
• Style Compliance: 9/10 - Button names Apply and Reset are correctly bolded in Sentence case; UI labels Spend, Total spend, Expenses are used exactly and bolded consistently. Navigation phrasing is specific ("In the footer, click the currency shown next to the Total spend amount"). Minor: bolding the word "offline" treats a state as a UI element, and "currency picker" is a generic descriptor rather than a confirmed UI label.

Key Findings

• Added content accurately reflects the shipped behavior: conversion with nothing selected, individual expenses (including off-page selections), reports, and grouped searches, plus the two disabled states (offline, totals loading).
• Headings are task-based and searchable, and steps follow the sequential/action-oriented standard.
• Structural violation: a new top-level heading is introduced. Governance permits only one top-level heading (the title) plus optional # FAQ. The existing article already uses multiple top-level headings, but this change adds another rather than using a second-level heading.
• The new FAQ entry ("Why cant I change the total spend currency?") follows the required question format and is exempt from task-based rules, but its answer would read better split into shorter sentences.
• internalScope remains absent from the frontmatter (mandatory per Section 3).

Recommendations

• Priority: Demote the new top-level heading "How to change the currency of the total spend on the Spend page" to a second-level heading so the article keeps a single top-level title (plus # FAQ).
• Confirm the currency selectors exact UI label; if it has a specific name, reference it exactly instead of the generic "currency picker."
• Consider adding the mandatory internalScope frontmatter field while the metadata is being edited.
• Optional: unbold the word "offline" (it is a state, not a UI control) and split the long FAQ answer into shorter sentences.

Files Reviewed

• docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md - Accurate, well-written addition; one structural top-level-heading issue and missing internalScope to address.

Note: Detailed line-by-line feedback has been provided as inline comments.

[MelvinBot]

Status is unchanged from my earlier comment: every real CI check is passing, and the only red one is Check independent approval (its Verify peer review step).

That's a process gate, not something a commit can fix — it clears once an independent reviewer approves this PR. There's no code change to push here.

[c3024]

@MelvinBot address github-actions bot comments.

[MelvinBot]

Addressed the github-actions HelpDot review. Pushed fdb1713.

Applied

• Heading hierarchy (priority + inline comment): Demoted the new section from # to ## How to change the currency of the total spend on the Spend page, and demoted its three sub-sections to ### so the nesting stays intact. This removes the new top-level # heading the diff was introducing.
• Unbolded "offline" in the disabled-cases list — it's a state, not a UI control.
• Split the FAQ answer into shorter sentences.

Not changed, with reasoning

• internalScope frontmatter: This mandatory field is absent from the entire article, not something this PR removed or introduced. Adding an accurate internalScope covers the whole article (report previews, tables, filters, smart suggestions, currency) and is a broader metadata cleanup that's out of scope for a currency-selector docs update. Flagging it here so it can be handled deliberately rather than guessed at.
• Exact "currency picker" UI label: I couldn't verify the control's exact in-product label this run (web browser control was unavailable), so I left the generic "currency picker" descriptor rather than invent a specific name. If it has a confirmed label, happy to swap it in.

One note on the heading rule: the single-#-per-article rule from the authoring spec is already deviated from across this whole article — "Report Previews", "Report Tables", "Filters", "Smart Suggestions", and "FAQ" are all # headings. My change stops this PR from adding a sixth, but bringing the full article into compliance would be a separate restructuring pass.

⚠️ Docs-only change; I could not verify rendering in a browser this run, but the changes are heading-level and copy edits confirmed against the diff.

[MelvinBot]

There's no code failure to fix here. The only failing check is Check independent approval, and the one "pending" check (build → Deploy ExpensifyHelp) is simply still running — not failing.

Check independent approval is a review-gating check, not a build/test/lint failure. It fails because this PR hasn't yet received an approval from an independent reviewer. It's not something I can resolve by pushing a commit — it will turn green on its own once an independent reviewer (someone other than the author) approves the PR.

Nothing in the diff is broken, so there's no fix to push. To clear the check, get an independent reviewer to approve.

Note: I couldn't verify anything in a browser for this run (web browser control was unavailable), but that isn't needed here — this is a docs-only PR and the failing check is purely a review-approval gate, determined from the checks metadata alone.

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://d86f31e1.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page