Fix crash: collection modified during enumeration in PackageRepository - #19
Merged
Merged
Conversation
ForceRefreshProperty was called inside the mPackages.Add loop, triggering CurrentPackageHasUpdateAvailable to enumerate repository.Packages while new entries were still being added. Moved both ForceRefreshProperty calls to after the loop completes (just before DownloadStatus = Complete). Fixes #14 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
emosaru
force-pushed
the
fix/issue-14-packagemanager-collection-crash
branch
from
April 11, 2026 23:33
49e96d6 to
da91db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForceRefreshPropertywas called inside themPackages.Addloop inMWebClient_DownloadDataCompleted, triggeringCurrentPackageHasUpdateAvailableto enumeraterepository.Packageswhile new entries were still being added to itForceRefreshPropertycalls to after the loop completes (once all packages are populated), just beforeDownloadStatus = CompleteTest plan
InvalidOperationException: Collection was modifiedcrash occursCloses #14
🤖 Generated with Claude Code