Runtime error after letting run for awhile

[codemann8]

Emotracker seems to crash for me after it is running for awhile. In my estimation around 30 minutes? It errors with this:

An exception of type 'System.InvalidOperationException' occurred in System.Private.CoreLib.dll but was not handled in user code: 'Collection was modified; enumeration operation may not execute.'
   at System.ThrowHelper.ThrowInvalidOperationException_InvalidOperation_EnumFailedVersion()
   at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
   at EmoTracker.Data.Packages.PackageManager.get_CurrentPackageHasUpdateAvailable() in C:\Programs\EmoTracker\EmoTracker.Data\Packages\PackageManager.cs:line 291
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)```

Win10 system

[codemann8]

Updated fix: codemann8@617da7a

However, I think this code as is is likely not right. I think its looping thru all of the installed packs and setting the ExistingPackage to the current loaded package? This seems not right. But the fix above should at least fix the exceptions that occur.

[emosaru]

Closed as fixed by #19

[codemann8]

This exception still occurs. It seems my fix for it isn't present in this branch. I think the fix that did get put in for this was also the same fix that Claude tried when I went thru it, but I had to do another round to resolve it.

[emosaru]

Fixed in PR #49. The enumeration in UpdatesAvailable and CurrentPackageHasUpdateAvailable now iterates over .ToList() snapshots of the collections to avoid the InvalidOperationException when they are modified concurrently during package update checks.

[codemann8]

Still occurs, was running on v3.0.1.10, line 292 of PackageManager.cs foreach (PackageRepositoryEntry entry in repository.Packages.ToList())

An exception of type 'System.ArgumentException' occurred in System.Private.CoreLib.dll but was not handled in user code: 'Destination array was not long enough. Check the destination index, length, and the array's lower bounds.'
   at System.Array.CopyImpl(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Boolean reliable)
   at System.Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length)
   at System.Collections.Generic.List`1.CopyTo(T[] array, Int32 arrayIndex)
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at EmoTracker.Data.Packages.PackageManager.get_CurrentPackageHasUpdateAvailable() in c:\Programs\EmoTracker\EmoTracker.Data\Packages\PackageManager.cs:line 292
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)```