Skip to content

Upgrade activity contributions to highscdouble #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Opt-Mucca merged 1 commit into from
Aug 14, 2026
Merged

Upgrade activity contributions to highscdouble #3184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions highs/mip/HighsDomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,29 @@
#include "mip/HighsCutPool.h"
#include "mip/HighsMipSolverData.h"

static double activityContributionMin(double coef, const double& lb,
const double& ub) {
static HighsCDouble activityContributionMin(double coef, const double& lb,
const double& ub) {
if (coef < 0) {
if (ub == kHighsInf) return -kHighsInf;

return coef * ub;
return coef * static_cast<HighsCDouble>(ub);
} else {
if (lb == -kHighsInf) return -kHighsInf;

return coef * lb;
return coef * static_cast<HighsCDouble>(lb);
}
}

static double activityContributionMax(double coef, const double& lb,
const double& ub) {
static HighsCDouble activityContributionMax(double coef, const double& lb,
const double& ub) {
if (coef < 0) {
if (lb == -kHighsInf) return kHighsInf;

return coef * lb;
return coef * static_cast<HighsCDouble>(lb);
} else {
if (ub == kHighsInf) return kHighsInf;

return coef * ub;
return coef * static_cast<HighsCDouble>(ub);
}
}

Expand Down Expand Up @@ -1276,7 +1276,7 @@ void HighsDomain::computeMinActivity(HighsInt start, HighsInt end,
HighsInt tmp;
double lb = getColLowerPos(col, infeasible_pos - 1, tmp);
double ub = getColUpperPos(col, infeasible_pos - 1, tmp);
double contributionmin = activityContributionMin(val, lb, ub);
HighsCDouble contributionmin = activityContributionMin(val, lb, ub);

if (contributionmin == -kHighsInf)
++ninfmin;
Expand All @@ -1293,7 +1293,7 @@ void HighsDomain::computeMinActivity(HighsInt start, HighsInt end,

assert(col < static_cast<HighsInt>(col_lower_.size()));

double contributionmin =
HighsCDouble contributionmin =
activityContributionMin(val, col_lower_[col], col_upper_[col]);

if (contributionmin == -kHighsInf)
Expand Down Expand Up @@ -1321,7 +1321,7 @@ void HighsDomain::computeMaxActivity(HighsInt start, HighsInt end,
HighsInt tmp;
double lb = getColLowerPos(col, infeasible_pos - 1, tmp);
double ub = getColUpperPos(col, infeasible_pos - 1, tmp);
double contributionmin = activityContributionMax(val, lb, ub);
HighsCDouble contributionmin = activityContributionMax(val, lb, ub);

if (contributionmin == kHighsInf)
++ninfmax;
Expand All @@ -1337,7 +1337,7 @@ void HighsDomain::computeMaxActivity(HighsInt start, HighsInt end,

assert(col < static_cast<HighsInt>(col_lower_.size()));

double contributionmin =
HighsCDouble contributionmin =
activityContributionMax(val, col_lower_[col], col_upper_[col]);

if (contributionmin == kHighsInf)
Expand Down Expand Up @@ -1420,7 +1420,7 @@ HighsInt HighsDomain::propagateRowUpper(const HighsInt* Rindex,
HighsInt numchgs = 0;
for (HighsInt i = 0; i != Rlen; ++i) {
HighsCDouble minresact;
double actcontribution = activityContributionMin(
HighsCDouble actcontribution = activityContributionMin(
Rvalue[i], col_lower_[Rindex[i]], col_upper_[Rindex[i]]);
if (ninfmin == 1) {
if (actcontribution != -kHighsInf) continue;
Expand Down Expand Up @@ -1463,7 +1463,7 @@ HighsInt HighsDomain::propagateRowLower(const HighsInt* Rindex,
HighsInt numchgs = 0;
for (HighsInt i = 0; i != Rlen; ++i) {
HighsCDouble maxresact;
double actcontribution = activityContributionMax(
HighsCDouble actcontribution = activityContributionMax(
Rvalue[i], col_lower_[Rindex[i]], col_upper_[Rindex[i]]);
if (ninfmax == 1) {
if (actcontribution != kHighsInf) continue;
Expand Down
Loading