Upgrade activity contributions to highscdouble - #3184
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3184 +/- ##
==========================================
+ Coverage 73.16% 73.19% +0.02%
==========================================
Files 430 432 +2
Lines 103967 105496 +1529
Branches 16718 16987 +269
==========================================
+ Hits 76069 77218 +1149
- Misses 27622 28002 +380
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
approved these changes
Aug 11, 2026
fwesselm
left a comment
fwesselm
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, @Opt-Mucca!
Collaborator
Author
|
@galabovaa I believe the two failing tests are completely unrelated. Are we fine to merge this? |
Collaborator
|
@Opt-Mucca, I restarted the failing tests, and they all passed on re-run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the infeasible instance attached by @zeddybot in #2866 (completely missed it in the wall of AI text)
Similar to the change @fwesselm did recently in #3149 (upgrades the precision of some terms). Given all calls to this were already summing their results into a
HighsCDouble, I assume the performance impact is truly negligible, but I'll still run a test to check.