chore: resolve remaining repository checker findings - #377
Merged
Conversation
- W5604: add missing "Seconds between data polling" key to all 10 non-English admin/i18n translation files (de, es, fr, it, nl, pl, pt, ru, uk, zh-cn) - S5005: use this.setTimeout()/this.clearTimeout() for the data polling timer in main.js so it is auto-cleared on unload - S5032: remove unused lib/tools.js (and its reference in .github/copilot-instructions.md) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second-wave cleanup for the open repository-checker issue #365. All errors from the first wave are already resolved on
main; this PR clears the remaining actionable warnings/suggestions.Fixed
admin/i18n/<lang>/translations.jsonforde, es, fr, it, nl, pl, pt, ru, uk, zh-cnwere each missing the English keySeconds between data polling(theintervalljsonConfig label). Added a proper translation to all ten files.main.jsused plainsetTimeout()/clearTimeout(). Converted tothis.setTimeout()/this.clearTimeout()inside the adapter class so the timer is auto-cleared on unload.lib/tools.js, which was dead code (not required anywhere in the repo); also dropped its stale mention from.github/copilot-instructions.md.Leftovers (deliberately not changed)
concurrencyblock intest-and-release.yml) — the checker wants the literal upstream form, but our form deliberately protects release/tag runs from cancellation. Accepted, documented deviation.admin/i18nfrom{lang}/translations.jsonto short{lang}.json) — optional format migration, left for a dedicated change rather than bundling it with a fix PR.Local verification
npm install --no-audit --no-fund— OKnpm run lint— 0 errors (3 pre-existing JSDoc@paramdescription warnings, untouched)npm run test:package— 57 passingnpm run test:integration— 1 passingnpm run test:integration-demo(the command CI runs) — 2 passingNote:
main.test.jscontains a leftover adapter-template dummy test that fails on theshould()syntax; it is pre-existing, unrelated to this change, and is not executed by CI or by any of the checker-relevant scripts.🤖 Generated with Claude Code