Skip to content

chore: resolve remaining repository checker findings - #377

Merged
DutchmanNL merged 1 commit into
mainfrom
chore/checker-wave2
Aug 24, 2026
Merged

chore: resolve remaining repository checker findings#377
DutchmanNL merged 1 commit into
mainfrom
chore/checker-wave2

Conversation

@DutchmanNL

Copy link
Copy Markdown
Collaborator

Second-wave cleanup for the open repository-checker issue #365. All errors from the first wave are already resolved on main; this PR clears the remaining actionable warnings/suggestions.

Fixed

  • W5604admin/i18n/<lang>/translations.json for de, es, fr, it, nl, pl, pt, ru, uk, zh-cn were each missing the English key Seconds between data polling (the intervall jsonConfig label). Added a proper translation to all ten files.
  • S5005 — the data-polling timer in main.js used plain setTimeout()/clearTimeout(). Converted to this.setTimeout() / this.clearTimeout() inside the adapter class so the timer is auto-cleared on unload.
  • S5032 — removed lib/tools.js, which was dead code (not required anywhere in the repo); also dropped its stale mention from .github/copilot-instructions.md.

Leftovers (deliberately not changed)

  • W3009 (concurrency block in test-and-release.yml) — the checker wants the literal upstream form, but our form deliberately protects release/tag runs from cancellation. Accepted, documented deviation.
  • W3052 / S3056 (workflow logs no longer retrievable for old runs) — nothing to fix in the repo; these age out and will clear on the next workflow runs.
  • S5601 (migrate admin/i18n from {lang}/translations.json to short {lang}.json) — optional format migration, left for a dedicated change rather than bundling it with a fix PR.

Local verification

  • npm install --no-audit --no-fund — OK
  • npm run lint — 0 errors (3 pre-existing JSDoc @param description warnings, untouched)
  • npm run test:package — 57 passing
  • npm run test:integration — 1 passing
  • npm run test:integration-demo (the command CI runs) — 2 passing

Note: main.test.js contains a leftover adapter-template dummy test that fails on the should() syntax; it is pre-existing, unrelated to this change, and is not executed by CI or by any of the checker-relevant scripts.

🤖 Generated with Claude Code

- W5604: add missing "Seconds between data polling" key to all 10
  non-English admin/i18n translation files (de, es, fr, it, nl, pl, pt,
  ru, uk, zh-cn)
- S5005: use this.setTimeout()/this.clearTimeout() for the data polling
  timer in main.js so it is auto-cleared on unload
- S5032: remove unused lib/tools.js (and its reference in
  .github/copilot-instructions.md)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@DutchmanNL
DutchmanNL merged commit 509d0f8 into main Aug 24, 2026
10 checks passed
@DutchmanNL
DutchmanNL deleted the chore/checker-wave2 branch August 24, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant