Repository navigation
Keep /dev/fb0 out of spawned scripts and show splashes with a moving bar - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 2.1.0.
/dev/fb0included, souistop(fromchmenu,uistart, a folder switch) killed them.MarkFdsCloseOnExec()(src/framework/close_on_exec.*) marks every fd >= 3 close-on-exec right before eachsystem(),popen()and fork+exec inoptions,save_managerandmod_uninstall. The menu keeps using its fds. The lifecycle's signal handler is left alone.omLoading [key...]:gen_splash --loadingnow takes the line keys, and draws them with the moving bar until the calling script exits ("Loading" without keys). The Wi-Fi backup splash uses it.omReloadMenushows the splash while the UI is stopped, instead of a black screen. WithomReloadMenuLaterit keeps the caller's text, so add-ons show one splash from start to finish.Tested on the console (SNES Classic, Super Famicom firmware):
system()inherited 16 fds with the old binary (/dev/fb0,/dev/mali,/dev/input/event*,/dev/tty0-1), and only its own with the new one.omReloadMenu(uistop+chmenu) to the end and the home menu came back, with the Loading splash.tests/run_tests.sh: 27/27 and 11/11. Plain and compat builds.