Repository navigation
Show the waiting splashes with a moving bar - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs Options Menu 2.1.0 (
omLoading, DefKorns/OptionsMenu#7).loadingSplashtakes the splash text and draws it withomLoading. It still allows one bar per script, so "Saving" followed by the list's "Loading" doesn't draw two bars over each other.getThemeListchecks for the downloader before the splash, so the bar doesn't keep drawing over the "downloader missing" message.Every caller is an EXTERNAL command that exits, or starts the next screen in the background, before that screen shows up, so the bar never draws over a menu.
Tested on the console: Update Theme List, DIY Preview/Save/Clean, and applying a theme after Refresh.