Skip to content

test+fix: parity-line e2e coverage, and fix #4 built-ins unreachable via REPL - #25

Merged
DDecoene merged 5 commits into
release/v1.0.0from
feature/e2e-parity-commands
Jun 27, 2026
Merged

test+fix: parity-line e2e coverage, and fix #4 built-ins unreachable via REPL#25
DDecoene merged 5 commits into
release/v1.0.0from
feature/e2e-parity-commands

Conversation

@DDecoene

Copy link
Copy Markdown
Owner

Brings Playwright e2e coverage up to date for everything shipped since the last e2e (MODIFY STRUCTURE, 2026-06-24), and fixes a real bug the e2e surfaced.

The bug (fixed)

The #4 built-ins (ROUND, MOD, MAX, MIN, TIME, YEAR, MONTH, DAY@kas2804's PR #17, shipped in 0.8.0) were implemented in Builtins.ts but never registered in the parser's BUILTIN_FUNCTIONS whitelist. So ? ROUND(3.14159, 2) failed with Unknown command: ( — the functions were unreachable from the REPL. The vitest unit tests passed only because they call callStateless directly, bypassing the parser. This is exactly the unit-vs-e2e gap that motivated this work. Fixed by registering the eight names; added tests/BuiltinsParse.test.ts (8 cases) that drive the functions through the parser as a regression guard.

New e2e — tests/parity-commands.spec.ts (4 tests)

Process fix

CLAUDE.md Definition of Done now requires a Playwright e2e per user-facing command, not just a unit test — the root cause of this drift.

Verification

Full vitest 224 passing, tsc clean; the 4 new e2e tests pass live against a real browser (re-ran independently).

Targets release/v1.0.0 per GitFlow.

@DDecoene DDecoene added this to the v1.0.0 — feature-complete milestone Jun 27, 2026
@DDecoene
DDecoene merged commit 2e269ef into release/v1.0.0 Jun 27, 2026
@DDecoene
DDecoene deleted the feature/e2e-parity-commands branch June 27, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant