Skip to content

ci: gate PRs with Playwright e2e + fix release-branch triggers - #26

Merged
DDecoene merged 1 commit into
release/v1.0.0from
chore/ci-e2e
Jun 27, 2026
Merged

ci: gate PRs with Playwright e2e + fix release-branch triggers#26
DDecoene merged 1 commit into
release/v1.0.0from
chore/ci-e2e

Conversation

@DDecoene

Copy link
Copy Markdown
Owner

Two real CI holes, fixed before the 1.0.0 release:

  1. CI never ran Playwright — only npm test (vitest) + build. That's how the More built-in functions: ROUND(), MOD(), MAX(), MIN(), TIME(), YEAR()/MONTH()/DAY() #4 built-ins shipped broken (unit-green, e2e-red, CI blind).
  2. CI only triggered on main. Under GitFlow every PR targets release/**, so PRs feat: implement ? / ?? print command (#2) #21test+fix: parity-line e2e coverage, and fix #4 built-ins unreachable via REPL #25 ran zero automated checks.

Changes

  • .github/workflows/ci.yml: trigger on push/PR to main and release/**; add an e2e job (playwright install --with-deps chromiumplaywright test), uploading the report artifact on failure.
  • playwright.config.ts: add a webServer block so the suite auto-starts the dev server (required in CI; reuses an already-running server locally). Verified locallynpx playwright test with no manual server starts one and passes.
  • CLAUDE.md DoD: both vitest and Playwright must pass; every user-facing feature ships an e2e case in the same PR; CI gates merge.

Targets release/v1.0.0 per GitFlow. This same CI config propagates to release/v1.1.0 when 1.0.0 reaches main.

@DDecoene
DDecoene merged commit 3786c1a into release/v1.0.0 Jun 27, 2026
2 checks passed
@DDecoene
DDecoene deleted the chore/ci-e2e branch June 27, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant