Skip to content

fix: clear the 👀, which the identity fallback silently prevented #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhenghuaBao merged 1 commit into from
Aug 26, 2026
Merged

fix: clear the 👀, which the identity fallback silently prevented #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1621,7 +1621,16 @@ runs:
echo "github-token belongs to a user, not an app; leaving reactions alone"
exit 0
fi
ME=$(gh api user --jq .login 2>/dev/null || echo "github-actions[bot]")
# SAME TRAP AS THE TYPE PROBE, and it survived the fix to that one: with an
# installation token `gh api user` can exit 0 and print nothing, so
# `|| echo` never fires and ME came back EMPTY. The delete filter then read
# `select(.user.login=="")`, matched nothing, and the 👀 stayed on the PR
# for ever while the step reported success. Observed on a clean run that
# placed both 👀 and 👍 and cleared neither.
#
# Test the VALUE, not the exit status.
ME=$(gh api user --jq .login 2>/dev/null) || ME=""
[ -n "$ME" ] || ME="github-actions[bot]"

# ------------------------------------------------------------------
# 👀 — it said "I am looking at this", and the run has stopped looking.
Expand Down
Loading