fix: clear the 👀, which the identity fallback silently prevented - #43
Merged
Conversation
The type probe was fixed last change; this is the same trap one line down, in the same step, and it survived. ME=$(gh api user --jq .login 2>/dev/null || echo "github-actions[bot]") With an installation token that call can exit 0 and print nothing, so `|| echo` never fires and ME comes back EMPTY. The delete filter then reads `select(.user.login=="")`, matches nothing, and the step reports success having removed nothing — so the 👀 stays on the PR for ever. Observed on a clean run that placed 👀, placed 👍, and cleared neither: both reactions were still on the PR afterwards, authored by github-actions[bot]. Tests the VALUE rather than the exit status, which is what the type probe now does too. Any future identity read in this step wants the same shape. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type probe was fixed in #42; this is the same trap one line down, in the same step, and it survived.
ME=$(gh api user --jq .login 2>/dev/null || echo "github-actions[bot]")With an installation token that call can exit 0 and print nothing, so
|| echonever fires andMEcomes back empty. The delete filter then readsselect(.user.login==""), matches nothing, and the step reports success having removed nothing — the 👀 stays on the PR for ever.Observed on a clean run: 👀 placed, 👍 placed, neither cleared, both still on the PR authored by
github-actions[bot].Tests the VALUE rather than the exit status, which is what the type probe now does too. Any future identity read in this step wants the same shape — the exit status of that endpoint is not a reliable signal for an installation token.