Skip to content

fix(moderation): the review queue still asked for the assessment type #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Sep 1, 2026
Merged

fix(moderation): the review queue still asked for the assessment type #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Controller/ModerationController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function __construct(
/**
* List the pending entries (of `type`) awaiting moderation.
*
* @param string $type The moderated object type ('organization', default, or 'assessment').
* @param string $type The moderated object type ('organization', default, or 'software-review').
*
* @return JSONResponse `{ok, items}` or a 400.
*
Expand All @@ -92,7 +92,7 @@ public function pending(string $type = ModerationService::MODERATED_TYPE): JSONR
* Approve a pending entry (of `type`).
*
* @param string $uuid The entry uuid.
* @param string $type The moderated object type ('organization', default, or 'assessment').
* @param string $type The moderated object type ('organization', default, or 'software-review').
*
* @return JSONResponse `{ok, status}` or a 400.
*
Expand All @@ -114,7 +114,7 @@ public function approve(string $uuid, string $type = ModerationService::MODERATE
* Reject a pending entry (of `type`).
*
* @param string $uuid The entry uuid.
* @param string $type The moderated object type ('organization', default, or 'assessment').
* @param string $type The moderated object type ('organization', default, or 'software-review').
*
* @return JSONResponse `{ok, status}` or a 400.
*
Expand Down
4 changes: 2 additions & 2 deletions lib/Service/SettingsService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public function getSettings(): array {
'usage',
'contract',
'connection',
'assessment',
'software-review',
'module',
'compliancy',
'moduleVersion',
Expand Down Expand Up @@ -4039,7 +4039,7 @@ private function configureVoorzieningen(): array {
'usage',
'contract',
'connection',
'assessment',
'software-review',
'module',
'compliancy',
'moduleversie',
Expand Down
2 changes: 1 addition & 1 deletion src/modals/Modals.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const GENERIC_MODAL_OBJECT_TYPES = [
'suite',
'service',
'vulnerability',
'assessment',
'software-review',
'compliancy',
'moduleVersion',
'sector',
Expand Down
2 changes: 1 addition & 1 deletion src/views/settings/StackiqSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
beoordeeling type, per catalog-ratings spec's "reuse the
pattern, don't invent a second mechanism" requirement. -->
<ModerationQueue
type="assessment"
type="software-review"
entityLabel="review"
:name="t('stackiq', 'Review moderation')"
:description="
Expand Down
Loading