fix(moderation): the review queue still asked for the assessment type - #914
Merged
Conversation
Development E2E caught this:
✘ reviews: an authenticated submission lands pending and is not yet public
Error: submitted review is not in the pending queue
✘ reviews: admin approval publishes the review and moves the aggregate
ModerationService::MODERATED_TYPE_REVIEW moved to software-review with the
slug, but the surfaces that ASK for that queue did not: StackiqSettings
renders ModerationQueue with type="assessment", and two SettingsService
object-type lists plus the Modals registry still named the old type. The
review was stored under the new slug and the queue looked under the old one,
so it always came back empty.
In this app the object type IS the schema slug, which SettingsService states
in its own comment and warns has silently killed this exact ratings feature
once before.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 711/711 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 08:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #894. Found by development E2E:
ModerationService::MODERATED_TYPE_REVIEWmoved tosoftware-reviewwith the slug, but the surfaces that ask for that queue did not:StackiqSettings.vue<ModerationQueue type="assessment">SettingsServicesrc/modals/Modals.vueModerationControllerThe review was stored under the new slug and the queue looked under the old one, so it always came back empty.
In this app the object type is the schema slug.
SettingsServicesays so in its own comment, and records that an unmapped type has silently killed this exact ratings feature once before. That is the second time this file's warning has proved right.The
sbom-import.spec.tsfailures in the same run are unrelated to this rename and are not addressed here.🤖 Generated with Claude Code