fix(nav): keep Projecten, because dossiq's board does not replace it - #1728
Merged
Conversation
#1672 merged while the correcting commit was still in flight, so development kept the Projecten removal and its `removalsReplacedBy: dossiq:WorkflowBoard` claim. This restores the entry. The gate was satisfied by asserting that dossiq's WorkflowBoard replaces pipelinq's Projects. It does not, and the difference is not cosmetic. `project` is not a planning surface here. It is a BILLING entity: it carries billable, budgetHours, budgetAmount, hourlyRate, ledgerSyncStatus and ledgerSyncedAt, and sixteen files hang off it — ShillinqWipService, TimeBillingHandoffService, LedgerController, LedgerSyncNotifier, ShillinqApService, ShillinqLedgerService and the two project listeners. Retiring it takes time-billing handoff, work-in-progress and the AP flow with it. dossiq's workflow board plans work. It carries no hourly rate and nothing on it feeds shillinq. Declaring the two equivalent makes gate-53 pass while leaving anyone who follows the pointer unable to do what the retired entry did — the loss ADR-044 exists to prevent, not an exemption from it. The four Reports retirements added by #1691 are untouched: those genuinely moved to the Reports page. Moving projects to dossiq stays possible, but it is a data-and-billing migration rather than a navigation edit, and the ledger integration needs somewhere to land first.
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 637/637 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 06:02 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Sep 2, 2026
…herwise (#1734) #1728 restored the Projecten menu entry and gave the reason: the removal rested on a claim that dossiq's WorkflowBoard replaces it, and it does not. `project` is a BILLING entity here, carrying billable, budgetHours, budgetAmount, hourlyRate and ledgerSync*, with sixteen files hanging off it. That PR touched only src/menu-layout.json, so the e2e assertion encoding the retracted claim stayed behind and has failed on development ever since: ✘ Projecten is no longer offered in the navigation 1 failed, 331 passed INVERTED, not deleted. The test asserted a LIMITATION that turned out to be wrong, and the behaviour now wanted is its opposite. Deleting it would leave nothing watching an entry that was already removed once by mistake, so it now asserts the entry IS present and carries the reason. `the projects page stays reachable by direct link` is untouched: retiring a menu entry never retired the route, and restoring the entry does not change that. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1672 merged while the correcting commit was still in flight, so development kept the Projecten removal and its
removalsReplacedBy: dossiq:WorkflowBoardclaim. This restores the entry.Why the claim is wrong
gate-53 was satisfied by asserting that dossiq's WorkflowBoard replaces pipelinq's Projects. It does not, and the difference is not cosmetic.
projectis not a planning surface here. It is a billing entity:billable,budgetHours,budgetAmount,hourlyRate,ledgerSyncStatus,ledgerSyncedAtShillinqWipService,TimeBillingHandoffService,LedgerController,LedgerSyncNotifier,ShillinqApService,ShillinqLedgerService, two listenersdossiq's workflow board plans work. It carries no hourly rate, and nothing on it feeds shillinq. Declaring the two equivalent makes the gate pass while leaving anyone who follows the pointer unable to do what the retired entry did — the loss ADR-044 exists to prevent, not an exemption from it.
Scope
Only
Projectsis removed fromremovalsandremovalsReplacedBy. The four Reports retirements added by #1691 are untouched: those genuinely moved to the Reports page.Committed through the GitHub API because another session has 75 files of in-flight e2e work in the local checkout, and switching branches there would have disturbed it.
Moving projects to dossiq stays possible, but it is a data-and-billing migration rather than a navigation edit, and the ledger integration needs somewhere to land first.