fix(e2e): Projecten is offered again, so invert the test that said otherwise - #1734
Merged
Merged
Conversation
…herwise #1728 restored the Projecten menu entry and gave the reason: the removal rested on a claim that dossiq's WorkflowBoard replaces it, and it does not. `project` is a BILLING entity here, carrying billable, budgetHours, budgetAmount, hourlyRate and ledgerSync*, with sixteen files hanging off it. That PR touched only src/menu-layout.json, so the e2e assertion encoding the retracted claim stayed behind and has failed on development ever since: ✘ Projecten is no longer offered in the navigation 1 failed, 331 passed INVERTED, not deleted. The test asserted a LIMITATION that turned out to be wrong, and the behaviour now wanted is its opposite. Deleting it would leave nothing watching an entry that was already removed once by mistake, so it now asserts the entry IS present and carries the reason. `the projects page stays reachable by direct link` is untouched: retiring a menu entry never retired the route, and restoring the entry does not change that.
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 637/637 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 07:33 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1728 restored the Projecten menu entry and gave the reason: the removal rested on a claim that dossiq's WorkflowBoard replaces it, and it does not.
projectis a billing entity here, carryingbillable,budgetHours,budgetAmount,hourlyRateandledgerSync*, with sixteen files hanging off it.That PR touched only
src/menu-layout.json, so the e2e assertion encoding the retracted claim stayed behind and has failed on development ever since:Inverted, not deleted
The test asserted a limitation that turned out to be wrong, and the behaviour now wanted is its opposite. Deleting it would leave nothing watching an entry that was already removed once by mistake, so it now asserts the entry is present and carries the reason in place.
the projects page stays reachable by direct linkis untouched: retiring a menu entry never retired the route, and restoring the entry does not change that.Where this leaves pipelinq e2e
The other four failures in this file's run were the Reports page, fixed by #1729 (nextcloud-vue 2.30.0). With this, development should be green.
🤖 Generated with Claude Code