feat(tasks): task expiry enforcement and configurable timeout/reject outcomes - #3338
Merged
Merged
Conversation
…outcomes Harvested from integriq's HITL semantics (fleet audit, wave 2): a task can now declare onTimeout and onReject in the reserved outcome vocabulary (skip|error|dead_letter). The timer sweep gains a third bounded range scan that closes non-terminal tasks past their enforcing deadline through the existing timer-outcome path (no second scheduler); a non-enforcing expiry timer falls back to the subject task's declared onTimeout; a rejecting completion of a task declaring onReject dead_letter records the dead-letter outcome through the same mapping. Both behaviours are serialized and carried by the user-task and portal-task nodes next to expiresAt.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 12:17 UTC
Download the full PDF report from the workflow artifacts.
The coverage guard correctly flagged the one untested addition: the migration adding on_timeout/on_reject and the expiry-scan index. Three cases: fresh table gets both columns and the index, a re-run changes nothing and returns null, an absent table is left alone.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 12:29 UTC
Download the full PDF report from the workflow artifacts.
lib/Migration is excluded from clover, so the previous commit recovered nothing; the actually-uncovered addition was TaskMapper::findDueTimeouts(). The new case pins the scan's predicates (openness, declared on_timeout, deadline order) and the floored batch limit.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 12:43 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wave 2 of the fleet task consolidation: the expiry and outcome semantics integriq's app-local HITL implementation had, moved into the shared task service (openspec change
task-expiry-and-outcomes).openregister_tasksgainson_timeoutandon_reject(nullable, reserved vocabularyskip|error|dead_letter) plus theor_tasks_open_expiry (is_terminal, expires_at)index (migrationVersion1Date20260902090000).TaskBuildervalidates both at intake;onTimeoutwithoutexpiresAtis refused by name.FlowTimerSweepgains a third bounded range scan: non-terminal tasks pastexpires_atthat declareon_timeoutare closed through the existingTaskService::applyTimerOutcome(). SameFlowTimerWorker, same pass, no second scheduler.onTimeout(an enforcingwettelijktimer's ownonExpirystill wins), becauseproject()nullsexpires_atafter the last expiry timer fires and would starve the scan.onReject: dead_letterrecords the dead-letter outcome through the same mapping the timer path uses;error/skipare stored for the resuming consumer and change nothing.expiresAt.Why
A task's
expires_atclaims to be the ENFORCING deadline but nothing enforced it without a wettelijk timer. integriq (and the next adopters) need timeout/reject behaviour to delegate onto; without it every app keeps its own sweep.Verification
--scope-to-diff: all applicable gates green.Companion PR follows in ConductionNL/integriq (adoption seam).