feat(approvals): mirror every HITL approval into the shared OpenRegister task service - #1812
Merged
Merged
Conversation
…ter task service The adoption seam for the fleet task consolidation (wave 2, depends on openregister task-expiry-and-outcomes): every suspension creates one shared task through TaskService::import() carrying the approver group, requester, expiresAt and the record's onTimeout/onReject, linked back via taskUuid; approve and reject close the mirror with the matching outcome; the shared timer sweep owns the mirror's expiry. A mirror failure never gates the approval flow. Full retirement of the app-local machinery is tracked as follow-up in the openspec change.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 2, 2026 12:45
4 tasks
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 141/141 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 13:05 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The adoption seam for wave 2 of the fleet task consolidation (openspec change
hitl-on-shared-tasks). Depends on ConductionNL/openregister#3338 (merged): tasks now carryonTimeout/onRejectand the shared timer sweep enforcesexpiresAt.ApprovalService::suspend*()(endpoint rule, flow step, synchronization gate, subscription gate) also creates ONE shared task through OpenRegister'sTaskService::import(): approver group as candidate group, requester,expiresAt, and the record'sonTimeout/onRejectwhen they are in the shared vocabulary. The task uuid lands on the approval_request astaskUuid.completeApproval()/reject()close the mirror with the matching outcome (approved,rejected, ordead_letterwhen the record'sonRejectrouted it there), attributed to the deciding user.onTimeout); integriq's ownApprovalTimeoutSweepJobkeeps resolving the record. Both are idempotent, so the pair converges without coordination.import(array $data, ?string $actor): Task,applyTimerOutcome(string $uuid, string $outcome, string $source, string $reason): Task).What this deliberately does NOT do
The approval_request stays the system of record for suspend/resume orchestration (FlowToken snapshots, resume ordering, consumption) — four callers compose that around this service, and retiring it in the seam PR would be a half-delete. Follow-ups are itemised in the openspec change's tasks.md section 2 and the tracking issue: task-first resolution via
TaskTransitionedEvent, retiring the app-local sweep for mirrored rows, delegating the approver notification, translating the mirror copy.Verification
--scope-to-diff: all 30 applicable gates green.