chore(format): prettier was never run over eighteen frontend files - #2089
Merged
Merged
Conversation
prettier --check has been failing on development over eighteen files: one component and seventeen test specs, all from the intake, outbound and digital-post work. Ran prettier --write and nothing else. No behaviour changes: the edits are line breaking and trailing commas. vitest 327 tests green, eslint 0 errors, prettier --check clean.
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 141/141 | |||
| npm | ✅ | ✅ 545/545 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ❌ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-09-19 12:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
prettier --check "**/*.{js,ts,vue,css,scss}"has been red ondevelopmentover eighteen files:
src/modals/v2/SourceFormFields.vueand seventeen testspecs from the intake, outbound and digital-post work.
What changed
prettier --writeover the tree, and nothing else. The edits are linebreaking, argument wrapping and trailing commas. No expression, selector or
assertion text changed.
Verified
npm run format: all matched files use Prettier code style. It waseighteen files failing.
npx vitest run: 22 files, 327 tests, all green, so the seventeen reformattedspecs still parse and still assert.
npm run lint: 0 errors, 112 warnings, unchanged fromdevelopment.Inherited, reported not fixed
phpcs (482 errors), phpmd (123 findings),
check:schema-l10n(261 overbaseline) and five hydra gates are red on
developmentindependently of thischange. Each is its own PR in this sweep.
🤖 Generated with Claude Code