Merge pull request #2089 from ConductionNL/chore/prettier-format

chore(format): prettier was never run over eighteen frontend files

Author: rubenvdlinde

src/modals/v2/SourceFormFields.vue

@@ -280,7 +280,10 @@
 					}}
 				</span>
 				<div
-					v-if="!digitalPostLoading && digitalPostProviderOptions.length === 0"
+					v-if="
+						!digitalPostLoading
+						&& digitalPostProviderOptions.length === 0
+					"
 					class="cn-source-form-fields__note">
 					{{
 						t(
@@ -450,7 +453,9 @@ export default {
 			const id = String(this.formData?.configuration?.provider ?? '')
 			if (!id) return null
 			return (
-				this.digitalPostProviderOptions.find((option) => option.id === id) ?? {
+				this.digitalPostProviderOptions.find(
+					(option) => option.id === id,
+				) ?? {
 					id,
 					label: id,
 				}
@@ -484,7 +489,11 @@ export default {
 			// The type can be switched after the form opened. Without this the
 			// picker would render with an empty list and read as "no binding
 			// installed" on an instance that has three.
-			if (this.showsDigitalPostPicker && this.digitalPostProviders.length === 0 && !this.digitalPostLoading) {
+			if (
+				this.showsDigitalPostPicker
+				&& this.digitalPostProviders.length === 0
+				&& !this.digitalPostLoading
+			) {
 				this.fetchDigitalPostProviders()
 			}
 		},

tests/e2e/digital-post-source.spec.ts

@@ -62,7 +62,9 @@ test.describe('digital post source', () => {
 			{ providerId: 'berichtenbox', senderOin: '00000001234567890000' },
 			`E2E berichtenbox no cert ${stamp}`,
 		)
-		const id = String(source.id ?? (source['@self'] as Record<string, string>)?.id)
+		const id = String(
+			source.id ?? (source['@self'] as Record<string, string>)?.id,
+		)
 
 		// Activation is enabling the source. The refusal has to reach the
 		// operator rather than surfacing at the first letter.
@@ -90,10 +92,9 @@ test.describe('digital post source', () => {
 	test('a flagged instance with no credentials refuses rather than simulating', async ({
 		request,
 	}) => {
-		const resp = await request.get(
-			'/index.php/apps/integriq/api/health',
-			{ failOnStatusCode: false },
-		)
+		const resp = await request.get('/index.php/apps/integriq/api/health', {
+			failOnStatusCode: false,
+		})
 		expect(resp.status()).toBe(200)
 
 		// The flag is off on a stock instance, so what this asserts is the
@@ -123,7 +124,10 @@ test.describe('digital post source', () => {
 				.toLowerCase()
 				.includes('berichtenbox'),
 		)
-		test.skip(entry === undefined, 'no Berichtenbox catalog entry on this instance')
+		test.skip(
+			entry === undefined,
+			'no Berichtenbox catalog entry on this instance',
+		)
 
 		const text = JSON.stringify(entry).toLowerCase()
 		// The product, and both credentials it cannot work without.

tests/e2e/intake-channels.spec.ts

@@ -32,7 +32,9 @@ const SECRET = 'e2e-intake-secret'
  */
 function sign(body: string): string {
 	const timestamp = Math.floor(Date.now() / 1000)
-	const signature = createHmac('sha256', SECRET).update(`${timestamp}.${body}`).digest('hex')
+	const signature = createHmac('sha256', SECRET)
+		.update(`${timestamp}.${body}`)
+		.digest('hex')
 
 	return `t=${timestamp},v1=${signature}`
 }
@@ -43,7 +45,10 @@ function sign(body: string): string {
  * @param request The Playwright request context.
  * @param channelId The channel id.
  */
-async function seedChannelSource(request: APIRequestContext, channelId: string): Promise<void> {
+async function seedChannelSource(
+	request: APIRequestContext,
+	channelId: string,
+): Promise<void> {
 	const resp = await request.post(`${OR_BASE}/source`, {
 		failOnStatusCode: false,
 		data: {
@@ -67,7 +72,10 @@ async function seedChannelSource(request: APIRequestContext, channelId: string):
  * @param request The Playwright request context.
  * @param rule The rule.
  */
-async function seedRule(request: APIRequestContext, rule: Record<string, unknown>): Promise<void> {
+async function seedRule(
+	request: APIRequestContext,
+	rule: Record<string, unknown>,
+): Promise<void> {
 	const resp = await request.post(`${OR_BASE}/intake_routing_rule`, {
 		failOnStatusCode: false,
 		data: rule,
@@ -89,14 +97,17 @@ async function deliver(
 	payload: Record<string, unknown>,
 ): Promise<Record<string, any>> {
 	const body = JSON.stringify(payload)
-	const resp = await request.post(`${API_BASE}/intake/channels/${channelId}/inbound`, {
-		failOnStatusCode: false,
-		headers: {
-			'Content-Type': 'application/json',
-			'X-OpenConnector-Signature': sign(body),
+	const resp = await request.post(
+		`${API_BASE}/intake/channels/${channelId}/inbound`,
+		{
+			failOnStatusCode: false,
+			headers: {
+				'Content-Type': 'application/json',
+				'X-OpenConnector-Signature': sign(body),
+			},
+			data: body,
 		},
-		data: body,
-	})
+	)
 	expect(resp.status(), 'a signed delivery must be accepted').toBe(202)
 
 	return await resp.json()
@@ -164,14 +175,18 @@ test.describe('intake channels', () => {
 		expect(result.status).toBe('held')
 		expect(result.reason).toContain('messaging')
 
-		await page.goto(`${APP_BASE}/messages/intake`, { waitUntil: 'domcontentloaded' })
+		await page.goto(`${APP_BASE}/messages/intake`, {
+			waitUntil: 'domcontentloaded',
+		})
 		await expect(
 			page.getByText('Een vraag zonder regel').first(),
 			'a held message is on the page somebody actually reads',
 		).toBeVisible({ timeout: 20_000 })
 	})
 
-	test('a mapping onto a field that does not exist fails at configuration time', async ({ request }) => {
+	test('a mapping onto a field that does not exist fails at configuration time', async ({
+		request,
+	}) => {
 		const resp = await request.post(`${API_BASE}/intake/routing-rules`, {
 			failOnStatusCode: false,
 			headers: { 'OCS-APIRequest': 'true' },
@@ -186,7 +201,9 @@ test.describe('intake channels', () => {
 
 		expect(resp.status(), 'the save must be refused').toBe(400)
 		const body = await resp.json()
-		expect(body.error, 'and it must name the field').toContain('veldDatNietBestaat')
+		expect(body.error, 'and it must name the field').toContain(
+			'veldDatNietBestaat',
+		)
 	})
 
 	test('an anonymous caller cannot change routing', async () => {
@@ -200,7 +217,11 @@ test.describe('intake channels', () => {
 		const resp = await anonymous.post(`${API_BASE}/intake/routing-rules`, {
 			failOnStatusCode: false,
 			headers: { 'OCS-APIRequest': 'true' },
-			data: { name: 'nope', channelId: 'messaging', targetSchema: 'algemene_vraag' },
+			data: {
+				name: 'nope',
+				channelId: 'messaging',
+				targetSchema: 'algemene_vraag',
+			},
 		})
 
 		expect(resp.status()).toBeGreaterThanOrEqual(401)

tests/e2e/mail-intake.spec.ts

@@ -53,7 +53,10 @@ async function seedMailbox(request: APIRequestContext): Promise<string> {
 }
 
 test.describe('mail intake', () => {
-	test('an operator imports a saved Outlook message', async ({ page, request }) => {
+	test('an operator imports a saved Outlook message', async ({
+		page,
+		request,
+	}) => {
 		const sourceId = await seedMailbox(request)
 		const file = readFileSync(join(__dirname, 'fixtures', 'outlook-message.msg'))
 
@@ -86,28 +89,33 @@ test.describe('mail intake', () => {
 		).toBe('ZAAK-2026-0042')
 
 		// The message is on the page an operator actually looks at.
-		await page.goto(`${APP_BASE}/messages/mail`, { waitUntil: 'domcontentloaded' })
+		await page.goto(`${APP_BASE}/messages/mail`, {
+			waitUntil: 'domcontentloaded',
+		})
 		await expect(
 			page.getByText('Vraag over ZAAK-2026-0042').first(),
 		).toBeVisible({ timeout: 20_000 })
 	})
 
-	test('a second import of the same message creates nothing new', async ({ request }) => {
+	test('a second import of the same message creates nothing new', async ({
+		request,
+	}) => {
 		const sourceId = await seedMailbox(request)
 		const file = readFileSync(join(__dirname, 'fixtures', 'outlook-message.msg'))
 
-		const importOnce = async () => await request.post(`${API_BASE}/mail-intake/import`, {
-			failOnStatusCode: false,
-			headers: { 'OCS-APIRequest': 'true' },
-			multipart: {
-				sourceId,
-				file: {
-					name: 'outlook-message.msg',
-					mimeType: 'application/vnd.ms-outlook',
-					buffer: file,
+		const importOnce = async () =>
+			await request.post(`${API_BASE}/mail-intake/import`, {
+				failOnStatusCode: false,
+				headers: { 'OCS-APIRequest': 'true' },
+				multipart: {
+					sourceId,
+					file: {
+						name: 'outlook-message.msg',
+						mimeType: 'application/vnd.ms-outlook',
+						buffer: file,
+					},
 				},
-			},
-		})
+			})
 
 		const first = await importOnce()
 		const second = await importOnce()

tests/e2e/migration-file-source.spec.ts

@@ -18,7 +18,8 @@ import { expect, test } from '@playwright/test'
 
 const API_BASE = '/index.php/apps/integriq/api/migration-sources'
 
-const DELIVERY = 'zaaknummer,naam,plaats\nZ-1,De Vries,Utrecht\nZ-2,Jansen,Amsterdam\n'
+const DELIVERY =
+	'zaaknummer,naam,plaats\nZ-1,De Vries,Utrecht\nZ-2,Jansen,Amsterdam\n'
 const SECOND_DELIVERY = 'zaaknummer,naam,plaats\nZ-3,Bakker,Veenendaal\n'
 
 /** The mapping an administrator authors once and stores. */
@@ -86,9 +87,7 @@ test.describe('migration sources', () => {
 		const secondBody = await second.json()
 		expect(secondBody.kinds[0].count).toBe(1)
 		expect(secondBody.kinds[0].sample[0].data.requesterName).toBe('Bakker')
-		expect(secondBody.kinds[0].sample[0].provenance.sourceIdentifier).toBe(
-			'Z-3',
-		)
+		expect(secondBody.kinds[0].sample[0].provenance.sourceIdentifier).toBe('Z-3')
 	})
 
 	// @e2e migration-sources::a-mapping-onto-a-field-that-does-not-exist-is-refused-at-save

tests/e2e/outbound-call-log.spec.ts

@@ -69,17 +69,24 @@ async function seedCall(
 }
 
 test.describe('outbound call log', () => {
-	test('a failed call is found without a container log', async ({ page, request }) => {
+	test('a failed call is found without a container log', async ({
+		page,
+		request,
+	}) => {
 		await seedCall(request, { statusMessage: 'E2E StUF fout op de partner' })
 
-		await page.goto(`${APP_BASE}/sources/logs`, { waitUntil: 'domcontentloaded' })
+		await page.goto(`${APP_BASE}/sources/logs`, {
+			waitUntil: 'domcontentloaded',
+		})
 		await expect(
 			page.getByText('E2E StUF fout op de partner').first(),
 			'the failure is on the screen, with the fault the partner returned',
 		).toBeVisible({ timeout: 20_000 })
 	})
 
-	test('a replay shows what it would send before it sends it', async ({ request }) => {
+	test('a replay shows what it would send before it sends it', async ({
+		request,
+	}) => {
 		const id = await seedCall(request)
 
 		const preview = await request.get(`${API_BASE}/calls/${id}/preview`, {
@@ -116,7 +123,9 @@ test.describe('outbound call log', () => {
 		).toBe(1)
 	})
 
-	test('a replay appends an attempt and leaves the first readable', async ({ request }) => {
+	test('a replay appends an attempt and leaves the first readable', async ({
+		request,
+	}) => {
 		const id = await seedCall(request)
 
 		const resp = await request.post(`${API_BASE}/calls/${id}/replay`, {
@@ -127,14 +136,19 @@ test.describe('outbound call log', () => {
 		expect(resp.status(), 'the replay must answer, not error').toBeLessThan(500)
 
 		const after = await (await request.get(`${OR_BASE}/call_log/${id}`)).json()
-		expect(after.attempts.length, 'the replay is an attempt on the same record').toBeGreaterThan(1)
+		expect(
+			after.attempts.length,
+			'the replay is an attempt on the same record',
+		).toBeGreaterThan(1)
 		expect(
 			after.attempts[0].outcome,
 			'and the attempt that failed first is still there, because it is why somebody looked',
 		).toBe('failed')
 	})
 
-	test('a replay can be asked to run under the current mapping version', async ({ request }) => {
+	test('a replay can be asked to run under the current mapping version', async ({
+		request,
+	}) => {
 		const id = await seedCall(request)
 
 		const resp = await request.post(`${API_BASE}/calls/${id}/replay`, {
@@ -157,18 +171,28 @@ test.describe('outbound call log', () => {
 			headers: { 'OCS-APIRequest': 'true' },
 			data: {
 				target: 'e2e-notificaties-partner',
-				request: { method: 'POST', endpoint: '/notificaties', body: { kanaal: 'zaken' } },
+				request: {
+					method: 'POST',
+					endpoint: '/notificaties',
+					body: { kanaal: 'zaken' },
+				},
 				dryRun: true,
 			},
 		})
 
 		expect(resp.status()).toBe(201)
 		const body = await resp.json()
-		expect(body.sent, 'a dry run of a hand-fired call sends nothing either').toBe(false)
+		expect(
+			body.sent,
+			'a dry run of a hand-fired call sends nothing either',
+		).toBe(false)
 		expect(body.request.endpoint).toBe('/notificaties')
 	})
 
-	test('an external verdict is visible, and changes nothing', async ({ page, request }) => {
+	test('an external verdict is visible, and changes nothing', async ({
+		page,
+		request,
+	}) => {
 		const seed = await request.post(`${OR_BASE}/verdict`, {
 			failOnStatusCode: false,
 			data: {
@@ -182,6 +206,8 @@ test.describe('outbound call log', () => {
 		expect(seed.status(), 'seeding a verdict must succeed').toBeLessThan(300)
 
 		await page.goto(`${APP_BASE}/verdicts`, { waitUntil: 'domcontentloaded' })
-		await expect(page.getByText('E2E ontbrekende bijlage').first()).toBeVisible({ timeout: 20_000 })
+		await expect(page.getByText('E2E ontbrekende bijlage').first()).toBeVisible({
+			timeout: 20_000,
+		})
 	})
 })