feat(signing): migrate onto the OR task surface (authored) - #988
Merged
rubenvdlinde merged 1 commit intoSep 1, 2026
Merged
Conversation
…rface onto OR task sequences openregister#3302 (flow-approval-consolidation) removes the four ApprovalStep*Event classes, the ApprovalChain/ApprovalStep entities and ApprovalService with no alias. The signing bridge now consumes the published replacements (TaskTransitionedEvent to enabled, TaskTerminalEvent committed, TaskSequenceCompletedEvent), registered by FQN string literal, duck-typed so the app loads with OpenRegister older, newer or absent. The Signer* events carry scalars, ownership moves from chain slugs to the anchored signing-request object, and a separate-process boot proof pins the load safety. Openspec change: migrate-signing-to-or-tasks.
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 1, 2026 20:09
Contributor
Quality Report — ConductionNL/filinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| test-unit | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 118/118 | |||
| npm | ✅ | ✅ 631/631 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 20:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical tree to #987 (byte-for-byte, rebuilt with correct authorship: the original branch's commits carried the release bot identity from a stale clone config and could not be force-rewritten under the fleet's push guards). Must merge in the same train as openregister#3302 (flow-approval-consolidation): filinq's ApprovalStep listeners are repointed onto TaskTransitionedEvent/TaskTerminalEvent/TaskSequenceCompletedEvent with a boot-without-retired-classes proof. See #987 for the full description; that PR will be closed in favour of this one.