feat(signing): migrate the signing bridge onto OR task sequences - #987
Closed
rubenvdlinde wants to merge 1 commit into
Closed
feat(signing): migrate the signing bridge onto OR task sequences#987rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…rface onto OR task sequences openregister#3302 (flow-approval-consolidation) removes the four ApprovalStep*Event classes, the ApprovalChain/ApprovalStep entities and ApprovalService with no alias. The signing bridge now consumes the published replacements (TaskTransitionedEvent to enabled, TaskTerminalEvent committed, TaskSequenceCompletedEvent), registered by FQN string literal, duck-typed so the app loads with OpenRegister older, newer or absent. The Signer* events carry scalars, ownership moves from chain slugs to the anchored signing-request object, and a separate-process boot proof pins the load safety. Openspec change: migrate-signing-to-or-tasks.
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 1, 2026 20:07
Contributor
Author
|
Superseded by #988: identical tree, corrected authorship (the branch commits carried a stale bot identity and force-rewrites are guard-blocked). |
Contributor
Quality Report — ConductionNL/filinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| test-unit | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 118/118 | |||
| npm | ✅ | ✅ 631/631 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 20:23 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
openregister#3302 (flow-approval-consolidation) removes the approval-chain surface with no alias. That covers the four ApprovalStep events, the ApprovalChain and ApprovalStep entities and mappers, ApprovalService, and the approval HTTP routes. filinq is the only consumer. Without this change the signing bridge dies the moment #3302 deploys.
This PR must merge in the same train as openregister#3302. Neither side ships alone: the retired classes disappear there, the replacements are consumed here.
What changed
Openspec change:
migrate-signing-to-or-tasks(proposal, design, spec delta and tasks included).Every touchpoint, old to new:
registerEventListener(ApprovalStep*Event::class, …)x4 inSigningEventRegistrarSigningTaskListeneronTaskTransitionedEvent,TaskTerminalEventandTaskSequenceCompletedEvent, registered by FQN string literalApprovalStepListener(chain slug filter, typed OR event handling)SigningTaskListener: class-string routing, duck-typed reads, ownership by resolving the anchor object in the configured signingRequest register/schemaApprovalStepInitiatedEventconsumptionTaskTransitionedEventwith stateenabledApprovalStepApprovedEvent/ApprovalStepRejectedEventTaskTerminalEvent, statecompleted, split on the rejecting outcome vocabularyApprovalStepCompletedEventTaskSequenceCompletedEventSigner*Eventpayloads carryingApprovalChain/ApprovalSteptypesApprovalService::approveStep/rejectStepTaskService::complete()with an approving or rejecting outcomeNo compatibility shim. The app loads with OpenRegister older, newer or absent. It follows the dossiq dual-namespace pattern, adapted to filinq's bootstrap-order rule: string literals and no class_exists() at register() time.
Boot proof
tests/scripts/boot-without-openregister.phpruns in a separate process. Its autoloader serves filinq's lib/ and the Nextcloud stubs only, no OpenRegister stub. It asserts all ten retired classes are unresolvable, force-links every signing-surface class, and runsSigningEventRegistrar::register().RetiredApprovalSurfaceTestexecs it and also sweeps lib/ and both register JSONs for every retired FQCN and route. Zero references remain.Checks
--scope-to-diff --base origin/development: 38 of 38 applicable gates, 0 FAILNotes for the reviewer
x-openregister-approval-chainsdeclaration, so there was no declarative block to migrate. Verified against both register JSONs.TaskService::complete()) has no live filinq call site. The archived change deferred the write-path rewrite (D1.x) andSigningServicestill drives the bespoke object rows. The spec delta pins the future rewrite to the task verbs so nobody rebuilds it against the retired names.flowpage type. CI and the current .github checkout pass it. Pre-existing, manifest untouched here.--reset-authorbefore squashing.