feat(cases): new case form defaults, Tasks as a tab, and spec ids out of user-facing text - #1723
Merged
Merged
Conversation
…s becomes a tab Three changes to the case surfaces, all manifest-level. The New case action seeds `assignee: @me` and `confidentiality: vertrouwelijk`. Both stay editable: `props` resolve through the token grammar and arrive as the dialog's initial values, not as fixed ones. Note that picking a case type still wins, because case.caseType carries an x-openregister-prefill mapping defaultAssignee onto assignee, which is the intended precedence: the type knows who handles its cases. Tasks moves into the case-panels tab strip, after Sub-cases, so the work items sit beside the case's own structure rather than as a tenth card down the page. It leaves `layout` in the same move: the tabs widget renders its children itself, so a widget left in both renders twice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A field's help text carried the requirement it traces to, so the intake channel dropdown told the person filling in a case "(REQ-INTAKE-08b, REQ-INTAKE-11a)". That is our traceability leaking into their screen. It means nothing to them and it costs the sentence its ending. 61 strings across the two register files: 54 where the id sat in brackets as a pure annotation and simply goes, and 7 where the id was load-bearing and the sentence needed rewriting instead. Those 7 are why this is not a regex. A first pass stripped bare ids mechanically and produced "Input type — drives validation in", a sentence ending on a preposition, which is worse than the id it removed. Each of the 7 is now rewritten in the Conduction voice, which also takes their em-dashes out per voice rule 8. Internal `_note` fields are untouched: traceability belongs there, and nobody reads them in the product. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 3, 2026 09:28
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 09:34 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three manifest-level changes to the case surfaces, plus a text cleanup on the registers.
The New case form opens with sensible defaults
The action seeds
assignee: @meandconfidentiality: vertrouwelijk. Both stay editable:propsresolve through the token grammar and arrive as the dialog's initial values, not as fixed ones.Worth knowing about precedence, because it is deliberate: picking a case type still overrides the assignee, since
case.caseTypecarries anx-openregister-prefillmappingdefaultAssigneeontoassignee. The type knows who handles its cases, so it should win over the current user.Tasks becomes a tab
Tasks moves into the
case-panelsstrip after Sub-cases, so work items sit beside the case's own structure instead of being a tenth card down the page. It leaveslayoutin the same move: the tabs widget renders its own children, so a widget left in both renders twice, which that widget's own_notewarns about.Spec ids out of text a user reads
A field's help text carried the requirement it traces to, so the intake channel dropdown told the person filling in a case
(REQ-INTAKE-08b, REQ-INTAKE-11a). That is our traceability leaking onto their screen: it means nothing to them and it costs the sentence its ending.61 strings across the two register files. 54 where the id sat in brackets as a pure annotation and simply goes; 7 where the id was load-bearing and the sentence needed rewriting.
Those 7 are why this is not a regex. My first pass stripped bare ids mechanically and produced "Input type — drives validation in", a sentence ending on a preposition, which is worse than the id it removed. I reverted that and rewrote each of the 7 in the Conduction voice, which also removes their em-dashes per voice rule 8.
Internal
_notefields are untouched: traceability belongs there, and nobody reads them in the product.A note on the diff size. An earlier attempt used a JSON writer that reformatted the whole register files into a 14,739-line diff. This is the surgical version: 18 changed lines per register file, formatting preserved.
Verification
check:manifestPASS against schema 2.29.0, pluscheck:schema-l10nandcheck:l10n-jsgreen. Zero spec ids remain in anydescription/title/label/placeholder/helpvalue acrosslib/Settings/**andsrc/**.Measured on the running instance before the changes: the new-case action still carries its nine
includeFields,columns: 2and the description textarea override, so the #1708/#1713 regression site is intact.🤖 Generated with Claude Code