test(e2e): name the prefill test after what it actually asserts - #1734
Merged
Conversation
The test was called "fills the title and assignee the chosen case type already answers" and only ever asserted the title. #1723 has since made the assignee half impossible to write at all: the new-case action's `props` seeds `assignee: "@me"`, prefill only fills EMPTY fields, so a case type's `defaultAssignee` can no longer reach the form. That is a reasonable product call — the person filing a case usually handles it — but it means the prefill mechanism is exercised through `title` and `status` and not through `assignee`. A name promising an assertion that cannot exist is worse than no name at all, because the next reader will go looking for the coverage. Renamed, and the interaction recorded where someone will meet it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 10:41 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The test was called
fills the title and assignee the chosen case type already answersand only ever asserted the title.#1723 has since made the assignee half impossible to write at all. The new-case action's
propsseedsassignee: "@me", and prefill only fills empty fields, so a case type'sdefaultAssigneecan no longer reach the form.That is a reasonable product call — the person filing a case usually handles it — but it means the prefill mechanism is exercised through
titleandstatus, not throughassignee. A name promising an assertion that cannot exist is worse than no name, because the next reader goes looking for coverage that was never there.Renamed, and the interaction recorded in a comment where someone will actually meet it.
Verification
--liststill collects 11 testsFor context, the e2e gate is green on
886c88a4(the merge of #1722): 171 passed, 0 failed, E2E Tests (Playwright) success, 35 jobs succeeded.🤖 Generated with Claude Code