fix(e2e): the task list spec required an empty register to pass - #1683
Merged
Conversation
`global task list page renders with add button and empty state` asserted `No items found` outright, so it could only pass on a register with zero tasks. The shared instance carries 8 task rows, measured on 2026-09-02, so the assertion could only ever fail there and had nothing to do with the feature. The scenario it covers is `task-management/spec.md#view-the-global-task-list`, and rows satisfy "view the global task list" better than emptiness does. It now accepts either the rendered rows or the empty state, and rejects neither. The Add Task button and the no-server-error assertion are unchanged, so the spec still fails if the page does not mount.
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 18:43 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global task list page renders with add button and empty stateassertedNo items foundoutright, so it could only pass on a register with zero tasks. The shared instance carries 8 task rows, so the assertion could only ever fail there, and the failure said nothing about the feature.The scenario it covers is
task-management/spec.md#view-the-global-task-list. Rows satisfy "view the global task list" better than emptiness does, so the test now accepts either the rendered rows or the empty state and rejects neither. The Add Task button and the no-server-error assertions are unchanged, so it still fails if the page does not mount.Verification
npx playwright test tests/e2e/spec-coverage/task-management.spec.tsagainst a live instance: 1 passed, having failed ondevelopmentimmediately before the changeeslint: 0 errors