Skip to content

E1.1.3 Carry the sign-off id into writer jobs and change records #26

Description

@CompleteDotTech

Part of: T3 sign-off is trust-only: no record is read or verified (E1.1).

Task

Carry the sign-off id into writer jobs and change records

Subtasks

  • Add approval_id to jobs created under the flag
  • Show it in doctor output

Definition of done

  • Tests added or updated and CI green
  • Docs updated when the command surface or output changes
  • No private registry data, local paths or private repository names in fixtures or docs

Activity

  1. CompleteDotTech commented on Oct 31, 2026

    @CompleteDotTech
    ContributorAuthor

    Clarification on the field name for this subtask (no change to the acceptance criteria).

    #26 says "add approval_id to jobs created under the flag". In the implementation in PR #123, writer jobs and change records carry the sign-off as signoff_id (and signoff_ids when several grants apply), and approval_id is never set from a sign-off: approval_id names the decisions/APPROVED_ACTIONS.yaml row that the writer guard looks up, so reusing it would blur two different records. Please read the #26 subtask as "carry the sign-off id as signoff_id". The behavior is documented in references/t3-signoff.md and SKILL.md, and covered by the tests in PR #123.

    Prior work: no earlier comment on this issue; PR #123 is the only PR covering it. Evidence of the exact-head validation will be in that PR; this comment is a clarification only and is not an approval of the PR.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/t3-consentCo-owner (T3) sign-off and consent gatesrollout-findingFound while rolling the showcase out to Pick-Your-AI

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions