You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
E1.1.3 Carry the sign-off id into writer jobs and change records #26
Clarification on the field name for this subtask (no change to the acceptance criteria).
#26 says "add approval_id to jobs created under the flag". In the implementation in PR #123, writer jobs and change records carry the sign-off as signoff_id (and signoff_ids when several grants apply), and approval_id is never set from a sign-off: approval_id names the decisions/APPROVED_ACTIONS.yaml row that the writer guard looks up, so reusing it would blur two different records. Please read the #26 subtask as "carry the sign-off id as signoff_id". The behavior is documented in references/t3-signoff.md and SKILL.md, and covered by the tests in PR #123.
Prior work: no earlier comment on this issue; PR #123 is the only PR covering it. Evidence of the exact-head validation will be in that PR; this comment is a clarification only and is not an approval of the PR.
Activity
CompleteDotTech commentedon Oct 31, 2026
Clarification on the field name for this subtask (no change to the acceptance criteria).
#26 says "add
approval_idto jobs created under the flag". In the implementation in PR #123, writer jobs and change records carry the sign-off assignoff_id(andsignoff_idswhen several grants apply), andapproval_idis never set from a sign-off:approval_idnames thedecisions/APPROVED_ACTIONS.yamlrow that the writer guard looks up, so reusing it would blur two different records. Please read the #26 subtask as "carry the sign-off id assignoff_id". The behavior is documented inreferences/t3-signoff.mdandSKILL.md, and covered by the tests in PR #123.Prior work: no earlier comment on this issue; PR #123 is the only PR covering it. Evidence of the exact-head validation will be in that PR; this comment is a clarification only and is not an approval of the PR.
🤖 Generated with Claude Code
Hold withdrawn repositories in T3 org profile, pins and captured Org …