Skip to content

T3 sign-off is trust-only: no record is read or verified #23

Open
0 of 4 issues completed
Open

Description

@CompleteDotTech

Status: Verified during the Pick Your AI rollout (reproduced, or read directly in the code).

Part of epic: Epic: Make co-owner (T3) sign-off auditable and safe.

Summary

SKILL.md says --allow-t3 may be passed "only after an approved t3-metadata or t3-signoff row", but no code reads such a row. check_owner(..., allow_t3) only tests a boolean.

Evidence

  • Brand.check_owner and Resolver.check_owner take a bool; nothing loads an approval row for T3.
  • A public checkout has no decisions/ or registry/ folder, so agents repeatedly asked where the sign-off was recorded.
  • During the rollout 17 agent sessions each demanded their own user's approval because the CLI gave them nothing to verify.

Impact

Anyone can pass the flag; reviewers cannot audit who approved which owner, repositories or period.

Proposed fix

Read a sign-off record (owner, scope, approver, date, optional expiry) and require the flag to match it.

Acceptance criteria

  • Without a matching record the flag is rejected with a clear log code.
  • Records can be scoped to repositories.
  • Jobs and change records carry the sign-off id.

Tasks

Each task below is a sub-issue.

Prior work

Prior work: open PR #20 (opt-in --allow-t3 and the Pick Your AI family), open #7 and PR #13 (variant J badges), merged PRs #14 to #19 (icon art-direction path, UTF-8 output, registry-free org health and label planning, Windows test portability, footer URL repair) and closed issues #8 to #12. Nothing here duplicates those; where an item is already handled it is linked, not refiled.

Fresh VM verification: not run. Findings were verified on a Windows host; hosted CI is separate evidence.

Activity

  1. 20 remaining items

  2. added 15 commits that reference this issue on Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/t3-consentCo-owner (T3) sign-off and consent gatesrollout-findingFound while rolling the showcase out to Pick-Your-AI

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions