Skip to content

fix(web): relaunch Chrome when it never opens its debugging port #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scttbnsn merged 1 commit into from
Oct 9, 2026
Merged

fix(web): relaunch Chrome when it never opens its debugging port #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/lighthouse-budget.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ export function isChromeConnectionError(error) {
/unable to connect to chrome/i.test(message) ||
/failed to fetch browser websocket url/i.test(message) ||
/chrome (has crashed|failed to launch|connection)/i.test(message) ||
// chrome-launcher's launch timeout: Chrome started and never wrote its
// DevTools port to chrome-err.log.
/waiting for dynamic debugging port/i.test(message) ||
/(target|session) closed/i.test(message)
) {
return true;
Expand Down
3 changes: 3 additions & 0 deletions scripts/lighthouse-budget.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ test("isChromeConnectionError matches Chrome/connection failures and not budget
);
assert.ok(isChromeConnectionError(new Error("read ECONNRESET")));
assert.ok(isChromeConnectionError(new Error("socket hang up")));
assert.ok(
isChromeConnectionError(new Error("waiting for dynamic debugging port in chrome-err.log")),
);
assert.ok(
!isChromeConnectionError(new Error("marketing performance budget exceeded: 0.5 < 0.66")),
);
Expand Down
Loading